wq! #2246
Closed
wq! #2246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support fstab mount with hyphens (#1993) * add normalise function for fstab flags * allow passing gcsfuse hyphen flags in persistent mount * add missing flags * revert normalisation changes as it is not required * fix typo * add unit test * review comments * review comments * review comments * Prefix grpc_conn_pool_size with "experimental_" --------- Co-authored-by: Kislay Kishore <kislayk@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support fstab mount with hyphens (#1993)
add normalise function for fstab flags
allow passing gcsfuse hyphen flags in persistent mount
add missing flags
revert normalisation changes as it is not required
fix typo
add unit test
review comments
review comments
review comments
Prefix grpc_conn_pool_size with "experimental_"
Description
Link to the issue in case of a bug fix.
NA
Testing details