Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Move KernelListCacheTtlSecs to List #2083

Merged
merged 2 commits into from
Jun 29, 2024
Merged

Revert "Move KernelListCacheTtlSecs to List #2083

merged 2 commits into from
Jun 29, 2024

Conversation

kislaykishore
Copy link
Collaborator

@kislaykishore kislaykishore commented Jun 29, 2024 •
edited
Loading

Description

This fixes the backward incompatibility that arose due to moving the kernel-list-cache-ttl-secs from file-system group to list.

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - Manually tested using the config file as input.
  2. Unit tests - NA
  3. Integration tests - NA

@kislaykishore kislaykishore added the execute-integration-tests Run only integration tests label Jun 29, 2024
@kislaykishore kislaykishore marked this pull request as ready for review June 29, 2024 05:19
@kislaykishore kislaykishore requested a review from a team as a code owner June 29, 2024 05:19
@kislaykishore kislaykishore requested review from vadlakondaswetha and raj-prince and removed request for a team June 29, 2024 05:19
@kislaykishore kislaykishore merged commit 33c0db5 into hotfix-v2.3.1 Jun 29, 2024
14 checks passed
kislaykishore added a commit that referenced this pull request Jun 29, 2024
@kislaykishore
Revert "Move KernelListCacheTtlSecs to List (#2083)
fcda672 
* Revert "Move KernelListCacheTtlSecs to List (#1985)"
* Make changes to the new config such that flag gets precedence over
  config-file for KernelListCacheTtlSecs.
This reverts commit d2e2ac5.
@BrewTestBot BrewTestBot mentioned this pull request Jun 29, 2024
Merged
@kislaykishore kislaykishore deleted the fix_backward_incompat branch July 2, 2024 02:25
kislaykishore added a commit that referenced this pull request Jul 2, 2024
@kislaykishore
Revert "Move KernelListCacheTtlSecs to List (#2083) (#2084)
94c1f4b 
* Revert "Move KernelListCacheTtlSecs to List (#1985)"
* Make changes to the new config such that flag gets precedence over
  config-file for KernelListCacheTtlSecs.
This reverts commit d2e2ac5.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raj-prince raj-prince raj-prince approved these changes

@vadlakondaswetha vadlakondaswetha Awaiting requested review from vadlakondaswetha vadlakondaswetha is a code owner automatically assigned from GoogleCloudPlatform/gcsfuse-codeowners

Assignees
No one assigned
Labels
execute-integration-tests Run only integration tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kislaykishore @raj-prince