Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Move KernelListCacheTtlSecs to List (#2083) [master] #2084

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

kislaykishore
Copy link
Collaborator

This change brings the hotfix for KernelListCacheTtlSecs to master.

Description

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - NA
  2. Unit tests - NA
  3. Integration tests - NA

* Revert "Move KernelListCacheTtlSecs to List (#1985)"
* Make changes to the new config such that flag gets precedence over
  config-file for KernelListCacheTtlSecs.
This reverts commit d2e2ac5.
Copy link

codecov bot commented Jun 29, 2024

Codecov Report

Attention: Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.23%. Comparing base (bc27ee8) to head (fcda672).
Report is 1 commits behind head on master.

Files Patch % Lines
cfg/config.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2084      +/-   ##
==========================================
- Coverage   72.27%   72.23%   -0.05%     
==========================================
  Files         100      100              
  Lines       10952    10950       -2     
==========================================
- Hits         7916     7910       -6     
- Misses       2707     2710       +3     
- Partials      329      330       +1     
Flag Coverage Δ
unittests 72.23% <93.33%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kislaykishore kislaykishore marked this pull request as ready for review June 29, 2024 06:19
@kislaykishore kislaykishore requested a review from a team as a code owner June 29, 2024 06:19
@kislaykishore kislaykishore merged commit 94c1f4b into master Jul 2, 2024
13 checks passed
@kislaykishore kislaykishore deleted the hotfix-master branch July 2, 2024 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants