[storage] feat: add post policy sample #3231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
frankyn
commented
Mar 31, 2020
•
frankyn
commented
- merge and release: feature: V4 Post policies googleapis/python-storage#87
- Update test to pass.
- GCS review from @jkwlui
- Python review
frankyn
added
the
do not merge
googlebot
added
the
cla: yes
frankyn
removed
the
do not merge
crwilcox
approved these changes
Apr 3, 2020
crwilcox
reviewed
Apr 3, 2020
|
|
||
| def generate_signed_post_policy_v4(bucket_name, blob_name): | ||
| """Generates a v4 POST Policy and prints an HTML form.""" | ||
| # bucket_name = 'your-bucket-name' |
There was a problem hiding this comment.
We do this in other samples also, but it seems odd to me that these aren't just documents in the docstring of the method. For instance https://github.com/GoogleCloudPlatform/python-docs-samples/blob/master/storage/cloud-client/storage_create_bucket.py#L25
There was a problem hiding this comment.
It's the way we've done it for a while now but open to changing it. IIUC it's part of sample expectations for Python and was approved.
jkwlui
reviewed
Apr 3, 2020
| form = header.format(policy["url"]) | ||
|
|
||
| # Include all fields returned in the HTML form as they're required | ||
| for index, (key, value) in enumerate(policy["fields"].items()): |
There was a problem hiding this comment.
for key, value in policy["fields"].items():
frankyn
added
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.