-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[storage] feat: add post policy sample #3231
Merged
Merged
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
805390e
feat: add post policy sample
frankyn 497d197
use 1.27.0
frankyn 741e5ab
Merge branch 'master' into post-policy-sample
frankyn f8c22cd
fix
frankyn b6717f9
Merge branch 'master' into post-policy-sample
jkwlui ab76a9f
simplify iterator
frankyn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,2 @@ | ||
google-cloud-pubsub==1.1.0 | ||
google-cloud-storage==1.26.0 | ||
google-cloud-storage==1.27.0 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
62 changes: 62 additions & 0 deletions
62
storage/cloud-client/storage_generate_signed_post_policy_v4.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,62 @@ | ||
#!/usr/bin/env python | ||
|
||
# Copyright 2020 Google Inc. All Rights Reserved. | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the 'License'); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
import sys | ||
|
||
# [START storage_generate_signed_post_policy_v4] | ||
from google.cloud import storage | ||
import datetime | ||
|
||
|
||
def generate_signed_post_policy_v4(bucket_name, blob_name): | ||
"""Generates a v4 POST Policy and prints an HTML form.""" | ||
# bucket_name = 'your-bucket-name' | ||
# blob_name = 'your-object-name' | ||
|
||
storage_client = storage.Client() | ||
|
||
policy = storage_client.generate_signed_post_policy_v4( | ||
bucket_name, | ||
blob_name, | ||
expiration=datetime.timedelta(minutes=10), | ||
fields={ | ||
'x-goog-meta-test': 'data' | ||
} | ||
) | ||
|
||
# Create an HTML form with the provided policy | ||
header = "<form action='{}' method='POST' enctype='multipart/form-data'>\n" | ||
form = header.format(policy["url"]) | ||
|
||
# Include all fields returned in the HTML form as they're required | ||
for index, (key, value) in enumerate(policy["fields"].items()): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
form += " <input name='{}' value='{}' type='hidden'/>\n".format(key, value) | ||
|
||
form += " <input type='file' name='file'/><br />\n" | ||
form += " <input type='submit' value='Upload File' name='submit'/><br />\n" | ||
form += "</form>" | ||
|
||
print(form) | ||
|
||
return form | ||
|
||
|
||
# [END storage_generate_signed_post_policy_v4] | ||
|
||
if __name__ == "__main__": | ||
generate_signed_post_policy_v4( | ||
bucket_name=sys.argv[1], blob_name=sys.argv[2] | ||
) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do this in other samples also, but it seems odd to me that these aren't just documents in the docstring of the method. For instance https://github.com/GoogleCloudPlatform/python-docs-samples/blob/master/storage/cloud-client/storage_create_bucket.py#L25
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's the way we've done it for a while now but open to changing it. IIUC it's part of sample expectations for Python and was approved.