Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove storage cloud-client samples #6978

Merged
merged 4 commits into from
Oct 28, 2021
Merged

chore: remove storage cloud-client samples #6978

merged 4 commits into from
Oct 28, 2021

Conversation

cojenco
Copy link
Contributor

@cojenco cojenco commented Oct 27, 2021 •
edited
Loading

Storage cloud-client samples are moved to https://github.com/googleapis/python-storage/tree/main/samples

cl/405930831 in review to resolve snippet-bot-check

ref: googleapis/python-storage#626 and internal cl/404660925 are merged

@snippet-bot
Copy link

snippet-bot bot commented Oct 27, 2021 •
edited
Loading

You are about to delete the following sample browser pages.

Here is the summary of changes.

You are about to delete 105 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Oct 27, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 27, 2021
@cojenco cojenco marked this pull request as ready for review October 27, 2021 17:57
@cojenco cojenco requested review from a team as code owners October 27, 2021 17:57
@cojenco cojenco added the snippet-bot:force-run Force snippet-bot runs its logic label Oct 27, 2021
@snippet-bot snippet-bot bot removed the snippet-bot:force-run Force snippet-bot runs its logic label Oct 27, 2021
@dandhlee
Copy link
Collaborator

dandhlee commented Oct 27, 2021 •
edited
Loading

It seems that the region tag in question has not been added yet from the other python-storage repo, I'll file a bug to have this looked into.

@cojenco
Copy link
Contributor Author

cojenco commented Oct 27, 2021

Thanks @dandhlee for taking a look! Checking on snippet tracker, I haven't seen any of the storage region tags in change being updated to the python-storage repo. For the hand written docs on devsite, I've manually updated the snippets include links per cl/404660925 and cl/405945620

@dandhlee
Copy link
Collaborator

Gotcha. The manual changes are fine for now but this won't be good down the road if the snippets were to change or need to be added/deleted. Will look into it.

@dandhlee
Copy link
Collaborator

Filed b/204346505 to look into this issue.

@leahecole
Copy link
Collaborator

love to see it! LGTM once snippet bot is happy - I'll keep an eye on the comments and that bug to see when it's resolved

dandhlee
dandhlee approved these changes Oct 28, 2021
View reviewed changes
Copy link
Collaborator

@dandhlee dandhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Snippet bot is happy, all is good :)

unforced
unforced approved these changes Oct 28, 2021
View reviewed changes
Copy link
Contributor

@unforced unforced left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dandhlee dandhlee merged commit 3cfcb0e into GoogleCloudPlatform:master Oct 28, 2021
leahecole pushed a commit that referenced this pull request Nov 16, 2021
@cojenco @leahecole
chore: remove storage cloud-client samples (#6978)
6434957 
* docs: update storage cloud client readme to redirect new location

* chore: remove storage cloud-client samples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unforced unforced unforced approved these changes

@dandhlee dandhlee dandhlee approved these changes

Assignees

@leahecole leahecole

Labels
cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cojenco @dandhlee @leahecole @unforced