Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove storage cloud-client samples #6978

Merged
merged 4 commits into from
Oct 28, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions storage/cloud-client/README.md
Original file line number Diff line number Diff line change
@@ -1,10 +1,3 @@
These samples have been moved.

For requester_pays_test.py, we need to use a different Storage bucket.

The test looks for an environment variable `REQUESTER_PAYS_TEST_BUCKET`.

Also, the service account for the test needs to have `Billing Project
Manager` role in order to make changes on buckets with requester pays
enabled.

We added that role to the test service account.
https://github.com/googleapis/python-storage/tree/main/samples
172 changes: 0 additions & 172 deletions storage/cloud-client/acl_test.py

This file was deleted.

176 changes: 0 additions & 176 deletions storage/cloud-client/bucket_lock_test.py

This file was deleted.

Loading