Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new: added --freeze flag #21

Merged
merged 6 commits into from
Jun 1, 2024
Merged

new: added --freeze flag #21

merged 6 commits into from
Jun 1, 2024

Conversation

EysseW
Copy link
Contributor

@EysseW EysseW commented Oct 6, 2023

Adds the --freeze and -F flags, which freeze your screen upon initialization. It can be very useful when you want to screenshot something that disappears quickly!
Depends on hyprpicker, though..

@EysseW
Copy link
Contributor Author

EysseW commented Dec 7, 2023

Anything wrong wit this?

@Gustash
Copy link
Owner

Gustash commented Dec 8, 2023

I just haven't had time to test, that's all 😅

@EysseW
Copy link
Contributor Author

EysseW commented Dec 8, 2023

I see, no stress!

@AxerTheAxe
Copy link

Works great for me, would love to see this merged!

@powwu
Copy link

powwu commented Jan 9, 2024

+1, would also love to see this merged

@EastArctica
Copy link

Would also love to see this merged if you have time!

@enk-it
Copy link

enk-it commented Mar 29, 2024

Guys this works fine, i would be happy to use it! Add it to main repo please!

@EastArctica
Copy link

I'll preface that I'm not actually 100% sure what is causing this. When you start a region screenshot with freeze and hit esc to cancel it, it only stops grim and hyprpicker continues running until you hit esc for the second time.

@ProMix0
Copy link
Contributor

ProMix0 commented Apr 11, 2024

I'll preface that I'm not actually 100% sure what is causing this. When you start a region screenshot with freeze and hit esc to cancel it, it only stops grim and hyprpicker continues running until you hit esc for the second time.

Try #36 - there hyprpicker get killed after slurp exit

@EysseW
Copy link
Contributor Author

EysseW commented May 8, 2024

Should be fixed now.

hyprshot Outdated
@@ -297,5 +306,5 @@ args $0 "$@"

SAVE_FULLPATH="$SAVEDIR/$FILENAME"
[ $CLIPBOARD -eq 0 ] && Print "Saving in: %s\n" "$SAVE_FULLPATH"
begin_grab $OPTION
begin_grab $OPTION & checkRunning
killHyprpicker
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this call the killHyprpicker function at the end when checkRunning already serves that purpose?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great point actually

@Gustash Gustash merged commit fddc086 into Gustash:main Jun 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants