Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new: added --freeze flag #21

Merged
merged 6 commits into from
Jun 1, 2024
Merged

new: added --freeze flag #21

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c80b3b6
new: added --freeze flag
myjnjb Oct 6, 2023
e3498b5
Forgot to remove debugging bit "echo 'initialized!'"
EysseW Oct 6, 2023
926aa24
fixed option order
EysseW Oct 6, 2023
ad494f8
kills hyprpicker properly
EysseW May 8, 2024
89b3d20
Update hyprshot
EysseW May 8, 2024
2516252
removed redundant code
EysseW May 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion hyprshot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,15 @@ function killHyprpicker() {
fi
}

function checkRunning() {
while [[ 1 == 1 ]]; do
if [[ $(pgrep slurp | wc -m) == 0 ]]; then
pkill hyprpicker
exit
fi
done
}

function begin_grab() {
if [ $FREEZE -eq 1 ] && [ "$(command -v "hyprpicker")" ] >/dev/null 2>&1; then
hyprpicker -r -z &
Expand Down Expand Up @@ -297,5 +306,5 @@ args $0 "$@"

SAVE_FULLPATH="$SAVEDIR/$FILENAME"
[ $CLIPBOARD -eq 0 ] && Print "Saving in: %s\n" "$SAVE_FULLPATH"
begin_grab $OPTION
begin_grab $OPTION & checkRunning
killHyprpicker
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this call the killHyprpicker function at the end when checkRunning already serves that purpose?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great point actually