-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create biblia-arabica-example-code.yml #129
Conversation
Hello, Thank you for this submission. Is it a work in progress or are you trying to submit it as is? There are several problems which need to be fixed before the entry can be added to the catalog.
That being said, my main issue is actually that I am not able to load the dataset in eScriptorium. I get the following errors when I do (see below), which might be caused by the fact that the value in "fileName" does not match the names of the image files. I tried on two instances of eScriptorium (v0.13.8b and v0.13.4b) with the same result. Did you try to import them in eScriptorium? Which version of eScriptorium did you use to export them? Did you generate them all in the command with Kraken? If yes, with which version? Note that some of the errors are normal, I didn't load all the images.
|
Thanks so much, and apologies that it took me a while before I saw your reply!
We would like to do more work on it but think it is already useful.
Done (see the above merges).
Will work on this -- basically explaining the image rights?
Yes, although there are only a few pages of the later material.
Done.
Sorry, I think the issue was changing filenames after download, without realizing this would mess up the METS import. I've corrected this now. (e.g. https://github.com/biblia-arabica/academies/tree/main/htr/ground-truth) Another main issue was that it wasn't so clear where the ground truth was. I've restructured to make this clearer. If you think https://github.com/biblia-arabica/academies/tree/main/htr/ground-truth is in order I will do the same for the other manuscripts. Thanks for your input! |
@alix-tz Can you have a look ? |
Updating the description to put the PR up to date with the discussion and the modification done in https://github.com/biblia-arabica/academies/blob/main/htr-united.yml
Adding missing information about volume and fixing license declaration
Ok, we are good now I believe! I'm sorry @nathangibson that this took so long, I hadn't realized that you had updated the metadata because you didn't report the changes in the file attached to this PR. But that shouldn't have blocked us from moving on with adding the description in the catalog. Thank you very much for your contribution! |
@alix-tz Thanks for this! And apologies, I'm not familiar with the process so I didn't realize about the file attached to the PR. I appreciate your including us! |
No description provided.