[display] diagnostics as json rpc #11412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "initialize" request has a "methods" field which lists all available methods. This way vshaxe can easily check if the new diagnostics method is available.
Yes, I want to get rid of as much legacy display stuff as possible for Haxe 5. |
I can open a PR after this one, that would remove legacy diagnostics while I know where to look. Then we can merge it [much] later when we want to get rid of it. |
0b1kn00b
pushed a commit
to 0b1kn00b/haxe
that referenced
this pull request
Jan 25, 2024
* [diagnostics] implement diagnostics as json rpc * [tests] use json rpc diagnostics * [tests] add tests for json rpc diagnostics * [diagnostics] no need for its own exception * [compiler] fix run_or_diagnose weird edge case * [diagnostics] no need for after_compilation callback anymore
kLabz
added a commit
that referenced
this pull request
Jul 3, 2024
This was referenced Jul 3, 2024
kLabz
added a commit
that referenced
this pull request
Jul 18, 2024
* [display] diagnostics as json rpc (Backport #11412) * [tests] use json rpc diagnostics * [tests] Add test for 11695 * [tests] Update diagnostics tests * Run some filters in diagnostics (#11220) * let's see how much breaks * [tests] enable diagnostics tests for 11177 and 11184 * [tests] Update test for 5306 * Don't cache/run filters for find reference/implementation requests (#11226) * Only run filters and save cache on diagnostics, not usage requests * [tests] Update test for 11184 * disable test * add VUsedByTyper to avoid bad unused local errors * revert @:compilerGenerated change --------- Co-authored-by: Rudy Ges <k@klabz.org> * [display] get rid of TypeloadParse.current_stdin * [display] fix -D display-stdin handling * [display] generalize fileContents behavior to other json rpc display calls * [display] fix range of pattern variables Note: not including texprConverter changes see 160a490 see #7282 * [tests] add test for #7282 * [tests] add test for #7931 * Remove populateCacheFromDisplay config Legacy diagnostics = false, json rpc diagnostics = true * [std] Diagnostics request doc * [tests] Test Json RPC diagnostics with several open files * [diagnostics] fix multi display files (#11722) * [diagnostics] fix json rpc diagnostics display config * [tests] Server tests: do not fail silently when runHaxeJsonCb errors * [tests] add more diagnostics tests * [display] rework multiple display files handling * clean up a bit... * [diagnostics] handle a.b.c.hx case, even if pointless * [diagnostics] do not skip errors during DisplayProcessing.process_display_file * Enable display tests again... * [tests] fix display tests --------- Co-authored-by: Simon Krajewski <simon@haxe.org>
kLabz
added a commit
that referenced
this pull request
Jul 18, 2024
* [display] diagnostics as json rpc (Backport #11412) * [tests] use json rpc diagnostics * [tests] Add test for 11695 * [tests] Update diagnostics tests * Run some filters in diagnostics (#11220) * let's see how much breaks * [tests] enable diagnostics tests for 11177 and 11184 * [tests] Update test for 5306 * Don't cache/run filters for find reference/implementation requests (#11226) * Only run filters and save cache on diagnostics, not usage requests * [tests] Update test for 11184 * disable test * add VUsedByTyper to avoid bad unused local errors * revert @:compilerGenerated change --------- Co-authored-by: Rudy Ges <k@klabz.org> * [display] get rid of TypeloadParse.current_stdin * [display] fix -D display-stdin handling * [display] generalize fileContents behavior to other json rpc display calls * [display] fix range of pattern variables Note: not including texprConverter changes see 160a490 see #7282 * [tests] add test for #7282 * [tests] add test for #7931 * Remove populateCacheFromDisplay config Legacy diagnostics = false, json rpc diagnostics = true * [std] Diagnostics request doc * [tests] Test Json RPC diagnostics with several open files * [diagnostics] fix multi display files (#11722) * [diagnostics] fix json rpc diagnostics display config * [tests] Server tests: do not fail silently when runHaxeJsonCb errors * [tests] add more diagnostics tests * [display] rework multiple display files handling * clean up a bit... * [diagnostics] handle a.b.c.hx case, even if pointless * [diagnostics] do not skip errors during DisplayProcessing.process_display_file * Enable display tests again... * [tests] fix display tests --------- Co-authored-by: Simon Krajewski <simon@haxe.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can't say I like the displayPosition hack :/
Not sure what the plan is on vshaxe side.. I suppose we need a way to tell it that it's available, with protocol version maybe?
Also, supposedly we'd remove legacy diagnostics around Haxe 5 release or something?
Closes #9134