Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Json rpc diagnostics #124

Merged
merged 10 commits into from
Jul 3, 2024
Merged

Conversation

kLabz
Copy link
Contributor

@kLabz kLabz commented Jul 2, 2024

  • Use Json RPC diagnostics if available (added in [display] diagnostics as json rpc HaxeFoundation/haxe#11412)
  • Removed (undocumented) populateCacheFromDisplay config, which is not needed with Json RPC diagnostics nor with recent nightlies; could technically be useful for older nightlies or 4.3.x but this hack has been removed so it's a bit of a PITA to continue to support it here
  • Had to update tests because [js] Use native maps when ES6 is enabled. HaxeFoundation/haxe#11698 changed iteration order for js maps
  • Added support for diagnostics on all open (Haxe) files in a single diagnostics request; can be disabled by config
    • TODO followup: add support for this config in vshaxe

@kLabz kLabz requested review from AlexHaxe and Simn July 2, 2024 13:57
@Simn
Copy link
Member

Simn commented Jul 2, 2024

I'm not very familiar with this code but at a glance it looks good.

@AlexHaxe
Copy link
Member

AlexHaxe commented Jul 3, 2024

I have only briefly run it on actual code, it seemed to work, but I haven't done any extensive testing.

code style wise curlies around single line bodies are preferred, but you'll easily find samples of rule breaking code throughout the project, so not a big deal (it might summon a Gama11).

other than that I see no blockers.

@kLabz
Copy link
Contributor Author

kLabz commented Jul 3, 2024

I fixed the curlies and prepared HaxeFoundation/haxe#11707 for Json RPC diagnostics on 4.3.5.

@AlexHaxe AlexHaxe merged commit 043df2a into vshaxe:master Jul 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants