Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[js] Use native maps when ES6 is enabled. #11698

Merged
merged 5 commits into from
Jun 22, 2024
Merged

[js] Use native maps when ES6 is enabled. #11698

merged 5 commits into from
Jun 22, 2024

Conversation

Apprentice-Alchemist
Copy link
Contributor

The implementation is from #10290
Closes #9303
Closes #7349

@Simn Simn merged commit f283deb into HaxeFoundation:development Jun 22, 2024
50 checks passed
@Apprentice-Alchemist Apprentice-Alchemist deleted the feature/js-es6-map branch June 22, 2024 11:34
@skial skial mentioned this pull request Jun 25, 2024
Closed
1 task
@kLabz kLabz mentioned this pull request Jul 2, 2024
Merged
@kLabz
Copy link
Contributor

kLabz commented Jul 2, 2024 •
edited
Loading

This changes IntMap behavior wrt for (item in map) order, which break Haxe LSP tests for example

@Simn Simn mentioned this pull request Aug 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ES6 Map vs. haxe.ds.ObjectMap
4 participants
@Apprentice-Alchemist @kLabz @Simn @ALANVF