Delay macro build order change #11622
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm against delaying this, if we want to make this change then the Haxe 5 release is the right time to do it. |
|
Yeah but is the first preview the right time, too? I don't plan on delaying it more than after first preview |
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I still think #11582 is needed in some way, it currently breaks many established macro-heavy projects that were built with the previous messed up build order.
I would like to work more on that at some point, if only to help with migrating such macros.
As it is, I fear it's too much of a breaking change and could drive people away from 5.0 nightlies so I would like to keep it under
-D haxe-nextfor a bit.