Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delay macro build order change #11622

Closed
wants to merge 2 commits into from
Closed

Delay macro build order change #11622

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a07f53
Only apply macro build order change with -D haxe-next for now
kLabz Mar 29, 2024
0723d19
Update tests
kLabz Mar 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/typing/typeloadCheck.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -512,7 +512,7 @@ module Inheritance = struct
match m with
| Meta.AutoBuild, el, p -> c.cl_meta <- (Meta.Build,el,{ c.cl_pos with pmax = c.cl_pos.pmin }(* prevent display metadata *)) :: m :: c.cl_meta
| _ -> ()
) (List.rev csup.cl_meta);
) (if (is_next ctx.com) then (List.rev csup.cl_meta) else csup.cl_meta);
if has_class_flag csup CFinal && not (((has_class_flag csup CExtern) && Meta.has Meta.Hack c.cl_meta) || (match c.cl_kind with KTypeParameter _ -> true | _ -> false)) then
raise_typing_error ("Cannot extend a final " ^ if (has_class_flag c CInterface) then "interface" else "class") p;
in
Expand Down
1 change: 1 addition & 0 deletions tests/misc/projects/Issue11582/compile.hxml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
-main Main
-D haxe-next
--interp
1 change: 1 addition & 0 deletions tests/server/build.hxml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
-lib hxnodejs
-lib utest
-lib haxeserver
-D haxe-next
-D analyzer-optimize
-D UTEST-PRINT-TESTS
#-D UTEST_PATTERN=ServerTests
Expand Down