Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add safe_loops in bicycle_parking quest #617

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

mcliquid
Copy link

Adding safe_loops in the bicycle_parking quest (see streetcomplete#5774)

@mnalis
Copy link
Collaborator

mnalis commented Aug 25, 2024

Note this part of: https://github.com/streetcomplete/issues/5774#issuecomment-2288512838

Ooops, sorry, I've missed that this PR is for SCEE, not StreetComplete. 😅
Bicycle expertise is fine to be required here IMHO. 👍

Have you tested that it works @mcliquid ?

@mcliquid
Copy link
Author

Have you tested that it works @mcliquid ?

@mnalis I checked out the quest in the emulator, if that's what you mean. That's part of it for me. I haven't programmed any unit tests, UI tests or anything like that for it, is that only necessary for a new value?

image
image
image
image
image

@Helium314 Helium314 merged commit 9f0d45e into Helium314:modified Aug 26, 2024
@mcliquid
Copy link
Author

@Helium314 Thank you!

@mnalis
Copy link
Collaborator

mnalis commented Aug 26, 2024

I checked out the quest in the emulator, if that's what you mean

Yes, that's what I've meant. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants