Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add bike_parking=safe_loops #2136

Merged

Conversation

beardhatcode
Copy link
Contributor

@beardhatcode beardhatcode commented Sep 11, 2024

I added a preset for bike_parking=safe_loops and I make an SVG myself.

I slightly altered the one in the repo to fit the format of one of the images that was already there, but I also have this image that I initially made:
safe_loops

I was unable to install the npm deps, so this is untested, but i think it should work 😅 (sorry).

@mcliquid
Copy link
Contributor

Since I have implemented this value in the corresponding quest in SCEE, I would like to suggest a change to the image:
safe_loops are an improved combination on rim mount and frame mount. From my point of view, the feature that the wheel is held on the tire / rim is somewhat missing in your image.
Check this reference: https://github.com/mcliquid/SCEE/blob/d9f32d81725c36aefd2c201a7334eee4b4532512/app/src/main/res/drawable-xxhdpi/bicycle_parking_type_safeloops.jpg

What do you think?

@pietervdvn
Copy link
Owner

Looks good!

I was unable to install the npm deps, so this is untested, but i think it should work 😅 (sorry).

Which is why the automated github action is in place :)
That one works, so it'll be fine.

@beardhatcode
Copy link
Contributor Author

beardhatcode commented Sep 11, 2024

I'm not sure, I am able to draw something like this:

safe_loops_2

But I'm not super fond of it, as the ones I encounter do not have such a design. It may be clearer however.

Should you have the skills feel free to suggest your own svg

@pietervdvn pietervdvn merged commit 41d543c into pietervdvn:develop Sep 11, 2024
1 check passed
@mcliquid
Copy link
Contributor

I'm not sure, I am able to draw something like this:

That looks really good from my point of view! It shows the two features very well! Thanks :)

@pietervdvn
Copy link
Owner

I've replaced the icon with the latest posted here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants