review: fix toMethod() implementation of CtRecordComponent to return useful spoon classes
#5801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Luro02
changed the title
toMethod() implementation of CtRecordComponent to return useful spoon classestoMethod() implementation of CtRecordComponent to return useful spoon classes
I-Al-Istannen
force-pushed
the
feature/factory-improvements
branch
from
d96b88e
to
8c95423
Compare
|
Can you fix the CI issues? |
I-Al-Istannen
force-pushed
the
feature/factory-improvements
branch
from
dcb8c76
to
05777d9
Compare
Luro02
commented
Jun 26, 2024
src/main/java/spoon/support/reflect/declaration/CtRecordComponentImpl.java
Outdated
Show resolved
Hide resolved
I-Al-Istannen
force-pushed
the
feature/factory-improvements
branch
from
ccc9d84
to
99da5e2
Compare
I-Al-Istannen
requested review from
SirYwell and
MartinWitt
and removed request for
SirYwell
SirYwell
requested changes
Aug 2, 2024
src/main/java/spoon/support/reflect/declaration/CtRecordComponentImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/spoon/support/reflect/declaration/CtRecordImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/spoon/support/reflect/declaration/CtRecordComponentImpl.java
Outdated
Show resolved
Hide resolved
…ul spoon classes
…tless doesn't fix it either???
This is a bit more consistent, but requires an ugly hotfix to eliminate duplicate fields.
I-Al-Istannen
force-pushed
the
feature/factory-improvements
branch
from
400932a
to
baa45a6
Compare
|
CI failure is unrelated and will fix itself. |
SirYwell
requested changes
Aug 30, 2024
src/main/java/spoon/support/reflect/declaration/CtRecordComponentImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/spoon/support/reflect/declaration/CtRecordComponentImpl.java
Show resolved
Hide resolved
I-Al-Istannen
force-pushed
the
feature/factory-improvements
branch
from
8a803ae
to
08ac164
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.