Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

review: fix toMethod() implementation of CtRecordComponent to return useful spoon classes #5801

Merged
merged 18 commits into from
Aug 31, 2024
Merged

review: fix toMethod() implementation of CtRecordComponent to return useful spoon classes #5801

merged 18 commits into from
Aug 31, 2024

Commits on Aug 30, 2024

  1. fix toMethod() implementation of CtRecordComponent to return usef… 

    …ul spoon classes
    @Luro02 @I-Al-Istannen
    Luro02 authored and I-Al-Istannen committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    50ba271 View commit details
    Browse the repository at this point in the history

  2. try to fix the tests

    @Luro02 @I-Al-Istannen
    Luro02 authored and I-Al-Istannen committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    271df81 View commit details
    Browse the repository at this point in the history

  3. for some reason intellij autocomplete doesn't add space there and spo… 

    …tless doesn't fix it either???
    @Luro02 @I-Al-Istannen
    Luro02 authored and I-Al-Istannen committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    2a6420c View commit details
    Browse the repository at this point in the history

  4. add javadoc

    @Luro02 @I-Al-Istannen
    Luro02 authored and I-Al-Istannen committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    2b2c57b View commit details
    Browse the repository at this point in the history

  5. add test-case

    @Luro02 @I-Al-Istannen
    Luro02 authored and I-Al-Istannen committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    b6c9a5c View commit details
    Browse the repository at this point in the history

  6. Remove unused import, expand star import

    @I-Al-Istannen
    I-Al-Istannen committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    698e39b View commit details
    Browse the repository at this point in the history

  7. Make test more precise and notice it fails now

    @I-Al-Istannen
    I-Al-Istannen committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    13a420e View commit details
    Browse the repository at this point in the history

  8. Build correct field reference in CtRecordComponentImpl

    @I-Al-Istannen
    I-Al-Istannen committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    444ccfe View commit details
    Browse the repository at this point in the history

  9. Add field as well in addCtRecordComponent 

    This is a bit more consistent, but requires an ugly hotfix to eliminate
duplicate fields.
    @I-Al-Istannen
    I-Al-Istannen committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    9d5ba42 View commit details
    Browse the repository at this point in the history

  10. Update src/main/java/spoon/support/reflect/declaration/CtRecordCompon… 

    …entImpl.java
    @Luro02 @I-Al-Istannen
    Luro02 authored and I-Al-Istannen committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    5494e90 View commit details
    Browse the repository at this point in the history

  11. Fix toMethod/toField if the type is null

    @I-Al-Istannen
    I-Al-Istannen committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    6cc7762 View commit details
    Browse the repository at this point in the history

  12. Extract cloned type into own method

    @I-Al-Istannen
    I-Al-Istannen committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    78d41b2 View commit details
    Browse the repository at this point in the history

  13. Move duplicate field fixing to ParentExiter

    @I-Al-Istannen
    I-Al-Istannen committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    6ddc4c5 View commit details
    Browse the repository at this point in the history

  14. Make toMethod in record components implicit

    @I-Al-Istannen
    I-Al-Istannen committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    6c39dc3 View commit details
    Browse the repository at this point in the history

  15. Delete leftover private method

    @I-Al-Istannen
    I-Al-Istannen committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    334e453 View commit details
    Browse the repository at this point in the history

  16. Placate quodana, we need to return null here

    @I-Al-Istannen
    I-Al-Istannen committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    baa45a6 View commit details
    Browse the repository at this point in the history

  17. Address review comments

    @I-Al-Istannen
    I-Al-Istannen committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    08ac164 View commit details
    Browse the repository at this point in the history

  18. Place annotation before type

    @I-Al-Istannen
    I-Al-Istannen committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    deccf16 View commit details
    Browse the repository at this point in the history