Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File upload use case: forbidden header error and progress bar fixes #187

Merged
merged 3 commits into from
Sep 4, 2024
Merged

File upload use case: forbidden header error and progress bar fixes #187

merged 3 commits into from
Sep 4, 2024

Conversation

ErykKul
Copy link
Contributor

@ErykKul ErykKul commented Sep 4, 2024

What this PR does / why we need it:

Trying to fix the remaining issue with file upload integration (frontend PR 464):

  • forbidden header errors/warning: Content-Length
  • progress bar not updating

Which issue(s) this PR closes:

Related Dataverse PRs:

  • Depends on #

Special notes for your reviewer:

Suggestions on how to test this:

Is there a release notes update needed for this change?:

Additional documentation:

@ErykKul ErykKul mentioned this pull request Sep 4, 2024
Merged
@ErykKul ErykKul added the Size: 3 A percentage of a sprint. 2.1 hours. label Sep 4, 2024
@ErykKul ErykKul changed the title frobidden header and progress bar fixes File upload use case: forbidden header error and progress bar fixes Sep 4, 2024
GPortas
GPortas approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@GPortas GPortas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfectly. I don't know why I made it so complicated in my initial implementation. Your approach is the best. @ErykKul

@GPortas GPortas merged commit 4537ac8 into develop Sep 4, 2024
5 checks passed
@GPortas GPortas deleted the frontend-417-upload-integration branch September 4, 2024 12:41
@GPortas GPortas added SPA.Q3.5 Enhanced File upload GREI Re-arch GREI re-architecture-related Original size: 3 labels Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GPortas GPortas GPortas approved these changes

Assignees
No one assigned
Labels
GREI Re-arch GREI re-architecture-related Original size: 3 Size: 3 A percentage of a sprint. 2.1 hours. SPA.Q3.5 Enhanced File upload
Projects
IQSS Dataverse Project
Status: Done 🧹
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integrate file upload page with js-dataverse use cases
2 participants
@ErykKul @GPortas