Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add isReleased to collection DvObjectOwnerNode. #199

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Add isReleased to collection DvObjectOwnerNode. #199

wants to merge 3 commits into from
+35 −2

Conversation

g-saracca
Copy link
Contributor

@g-saracca g-saracca commented Oct 1, 2024 •
edited
Loading

What this PR does / why we need it:

Adds isReleased to collection DvObjectOwnerNode.

Which issue(s) this PR closes:

Related Dataverse PRs:

Suggestions on how to test this:

Visual inspection of code and github action executions

@g-saracca g-saracca added Size: 3 A percentage of a sprint. 2.1 hours. SPA: Dataset View Page GREI Re-arch GREI re-architecture-related SPA.Q3.6 Publish Collection FY25 Sprint 7 FY25 Sprint 7 (2024-09-25 - 2024-10-09) Original size: 10 labels Oct 1, 2024
@ekraffmiller ekraffmiller self-assigned this Oct 3, 2024
ekraffmiller
ekraffmiller previously approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@ekraffmiller ekraffmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@g-saracca
Copy link
Contributor Author

Please remember:
⚠️ Environment variables should be changed to unstable image tag before merging into develop. IQSS/dataverse#10882 should be merged before applying this change.

@ofahimIQSS ofahimIQSS self-assigned this Oct 7, 2024
@ofahimIQSS ofahimIQSS removed their assignment Oct 7, 2024
@g-saracca
Copy link
Contributor Author

g-saracca commented Oct 7, 2024 •
edited
Loading

IQSS/dataverse#10882 should be tested and merged before this one

@ekraffmiller
Copy link
Contributor

removed the Waiting tag, since the Dataverse issue has been merged

@ofahimIQSS ofahimIQSS self-assigned this Oct 9, 2024
@GPortas GPortas added SPA.Q4 Not related to any specific Q4 feature and removed SPA.Q3.6 Publish Collection labels Oct 9, 2024
@g-saracca
Copy link
Contributor Author

Updated .env dataverse image to unstable since the Dataverse related issue has been merged.

@g-saracca
Copy link
Contributor Author

@ekraffmiller could you review again? I have changed the dataverse image to unstable, thanks!

@ofahimIQSS
Copy link

@g-saracca Where are the functional tests for this PR?

@g-saracca
Copy link
Contributor Author

@ofahimIQSS Oh, I didn't think it was necessary to validate the isPartOf field in a functional test since it was already being tested through an integration test, that's why there are none.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekraffmiller ekraffmiller ekraffmiller left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@ofahimIQSS ofahimIQSS

Labels
FY25 Sprint 7 FY25 Sprint 7 (2024-09-25 - 2024-10-09) GREI Re-arch GREI re-architecture-related Original size: 10 Size: 3 A percentage of a sprint. 2.1 hours. SPA: Dataset View Page SPA.Q4 Not related to any specific Q4 feature
Projects
IQSS Dataverse Project
Status: QA ✅
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add 'isReleased' to DvObjectOwnerNode, for collections when returning owners
4 participants
@g-saracca @ekraffmiller @ofahimIQSS @GPortas