Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add isReleased field to isPartOf #10882

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

stevenwinship
Copy link
Contributor

What this PR does / why we need it:
When the owner entity is a collection, we need to include the isReleased field within the isPartOf object.

Which issue(s) this PR closes: #10849

Closes #10849

Special notes for your reviewer:

Suggestions on how to test this: See IT test

Does this PR introduce a user interface change? If mockups are available, please link/include them here: No

Is there a release notes update needed for this change?:

Additional documentation:

@stevenwinship stevenwinship self-assigned this Sep 25, 2024
@stevenwinship stevenwinship added FY25 Sprint 7 FY25 Sprint 7 (2024-09-25 - 2024-10-09) Type: Feature a feature request Size: 10 A percentage of a sprint. 7 hours. SPA These changes are required for the Dataverse SPA GREI Re-arch Issues related to the GREI Dataverse rearchitecture SPA.Q3 Not related to any specific Q3 feature labels Sep 25, 2024
@coveralls
Copy link

Coverage Status

coverage: 20.872% (-0.001%) from 20.873%
when pulling eaa8e5d on 10849-add-isreleased-field-to-ispartof
into d40ce32 on develop.

@stevenwinship stevenwinship removed their assignment Sep 25, 2024

This comment has been minimized.

@stevenwinship stevenwinship changed the title add isRelease field to isPartOf add isReleased field to isPartOf Sep 25, 2024
@ekraffmiller ekraffmiller self-assigned this Sep 26, 2024
Copy link
Contributor

@ekraffmiller ekraffmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@stevenwinship stevenwinship force-pushed the 10849-add-isreleased-field-to-ispartof branch from eaa8e5d to 7cc81e0 Compare October 8, 2024 17:36
Copy link

github-actions bot commented Oct 8, 2024

📦 Pushed preview images as

ghcr.io/gdcc/dataverse:10849-add-isreleased-field-to-ispartof
ghcr.io/gdcc/configbaker:10849-add-isreleased-field-to-ispartof

🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name.

@ofahimIQSS
Copy link
Contributor

Testing completed, no issues found

10882 Testing.docx

@ofahimIQSS ofahimIQSS merged commit 45bdf5a into develop Oct 8, 2024
18 of 19 checks passed
@ofahimIQSS ofahimIQSS deleted the 10849-add-isreleased-field-to-ispartof branch October 8, 2024 18:27
@ofahimIQSS ofahimIQSS removed their assignment Oct 8, 2024
@pdurbin pdurbin added this to the 6.5 milestone Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FY25 Sprint 7 FY25 Sprint 7 (2024-09-25 - 2024-10-09) GREI Re-arch Issues related to the GREI Dataverse rearchitecture Original size: 10 Size: 10 A percentage of a sprint. 7 hours. SPA.Q3 Not related to any specific Q3 feature SPA These changes are required for the Dataverse SPA Type: Feature a feature request
Projects
Status: Done 🧹
Development

Successfully merging this pull request may close these issues.

Add 'isReleased' as a field in the 'isPartOf' object for collections when returning owners
6 participants