Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Dataverse: Allow super user to move a dataverse and reindex it and all child objects. #2278

Closed
kcondon opened this issue Jun 17, 2015 · 9 comments
Labels
Feature: Dataverse General Info Edit dataverse > "General Information" > Name, Alias, Email, Metadata Fields, et al... Feature: Search/Browse Feature: Superuser Dashboard Help Wanted: Code Mentor: pdurbin Type: Suggestion an idea User Role: Superuser Has access to the superuser dashboard and cares about how the system is configured User Role: Sysadmin Installs, upgrades, and configures the system, connects via ssh

Comments

@kcondon
Copy link
Contributor

kcondon commented Jun 17, 2015

I've recently received 2 separate requests to move dataverses through the DB. The moving part is easy -just change the owner id of the dv to be moved. To make it visible in the new location, you need to index the dv, then index all sub dv's and sub datasets individually.

I know this was originally a feature but I'm asking for it as a super user tool that includes indexnig for now until the bigger picture is sorted out.

Luckily the most recent request only requires 2 dv's and 22 datasets to be indexed.

While we're at it, add in an index super user tool as well like in v3.6: just drop in a list of ids, it does the rest. I'll open a separate ticket.

Related to #2226

@pdurbin
Copy link
Member

pdurbin commented Jun 17, 2015

Related: #283 and the "Implications of moving dataverses and datasets" doc.

@kcondon
Copy link
Contributor Author

kcondon commented Aug 12, 2015

I have moved countless datasets and dataverses manually through the db, including the gigantic PSI. There were 3 separate requests today alone! Stop the madness!

@mercecrosas
Copy link
Member

👍

@pdurbin
Copy link
Member

pdurbin commented Jan 15, 2016

I have moved countless datasets and dataverses manually through the db

@kcondon can you please write down any guidelines based on your real-world experience of moving datasets and dataverses through the database? I know that in some cases reindexing is required but I'm also wondering about the concerns we had expressed in the doc I mentioned previously:

Basically, any case where inheritance comes into play should be considered. I'm not even sure if we have a complete list of this anywhere since facet selections at the dataverse level should probably be added to the list of concerns above.

@scolapasta this should probably be treated at a project/feature. Are we implementing this as an API call available to superusers only? That would be the easiest thing so there's no GUI to worry about.

There's a MoveDataverseCommandTest class that @michbarsinai added long ago that could/should be greatly expanded especially in light of his "The Testable Command" doc/implementation he's working on at https://github.com/IQSS/dataverse/blob/2746-testable-commands/doc/theTestableCommand/TheTestableCommand.md . As of this writing the tests only check that you can move a dataverse to a sibling but not a dataverse to its own child. And of course the MoveDataverseCommand itself doesn't work. It was never made real. And there's no MoveDatasetCommand at all (I suppose we could dedicate #2226 to this). This is what I mean when I say this is a project. I can't imagine this would be developed quickly.

Finally, the subject of this issue says "reindex it [the moved dataverse] and all child objects" but we don't support such a concept at all in indexing. It would be nice, of course, but this could be split out and developed separately.

@mheppler mheppler added Feature: Search/Browse Feature: Dataverse General Info Edit dataverse > "General Information" > Name, Alias, Email, Metadata Fields, et al... labels Jan 28, 2016
@scolapasta scolapasta removed this from the Not Assigned to a Release milestone Jan 28, 2016
@tlchristian
Copy link

We are up to our elbows moving datasets to dataverses and dataverses to other dataverse in preparation of our migration. Front-end functionality would be immensely helpful.

@pdurbin
Copy link
Member

pdurbin commented Sep 15, 2016

@tlchristian Amber from Scholars Portal (not sure if she's on GitHub or I'd @mention her) brought this up on this week's community call: https://docs.google.com/document/d/1_IrtixbLPDPU7B73EhwJML9t_hfpqs3tdxRGXYb8e0k/edit?usp=sharing

@pdurbin
Copy link
Member

pdurbin commented Dec 2, 2016

This issue was mentioned at https://help.hmdc.harvard.edu/Ticket/Display.html?id=244231 - "tinkering in any production database by hand isn't good for my blood pressure." 😄

@pdurbin
Copy link
Member

pdurbin commented Jan 26, 2017

See also the "How to move dv's, ds" doc at https://docs.google.com/document/d/1A2v_ylLIRLIV6UpkDAJNNiFQt7q3SrAtAvQmg4nHBoY/edit?usp=sharing mentioned at https://groups.google.com/d/msg/dataverse-community/polE7z9_-NE/3xwAxgIHGgAJ

Here are the related issued:

@pdurbin pdurbin added User Role: Superuser Has access to the superuser dashboard and cares about how the system is configured User Role: Sysadmin Installs, upgrades, and configures the system, connects via ssh labels Jul 4, 2017
@djbrooke
Copy link
Contributor

Closing as a duplicate of #4406

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Dataverse General Info Edit dataverse > "General Information" > Name, Alias, Email, Metadata Fields, et al... Feature: Search/Browse Feature: Superuser Dashboard Help Wanted: Code Mentor: pdurbin Type: Suggestion an idea User Role: Superuser Has access to the superuser dashboard and cares about how the system is configured User Role: Sysadmin Installs, upgrades, and configures the system, connects via ssh
Projects
None yet
Development

No branches or pull requests

8 participants