Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataset Page - File Options Kebab Btn 🍡 #7081

Closed
djbrooke opened this issue Jul 14, 2020 · 4 comments · Fixed by #7353
Closed

Dataset Page - File Options Kebab Btn 🍡 #7081

djbrooke opened this issue Jul 14, 2020 · 4 comments · Fixed by #7353
Assignees

Comments

@djbrooke
Copy link
Contributor

djbrooke commented Jul 14, 2020

Change the file table button style and appearance in the UI to maximum 3 icon buttons (3rd being "kabob" to display additional actions in a dropdown) to add scalability for future file-level actions.

Pulling this out as an individual issue from #6605. Link to mockup: https://www.sketch.com/s/c6f49cf6-795a-4138-931c-fd962ae2542a/a/Emwabv

@TaniaSchlatter
Copy link
Member

TaniaSchlatter commented Jul 15, 2020

When designing the button changes on the dataset page, we worked with the concept of using a "kebab" icon to support situations when there are many actions. The idea is to display up to 3 action buttons, and if there are 4 or more actions, display the "kebab" icon with a drop down, and include actions 4+ in the dropdown.

We need to define how this might happen, and details, even though the visual detail has been designed.

Screen Shot 2020-07-15 at 12 59 52 PM

I propose a Discovery phase with the following steps and outcomes:

  • Gather and conduct a preliminary review of related GitHub issues. Flag questions for follow up (@mheppler) and put them in the Design doc.
  • Identify what's missing/what we need to know. Confirm: what are we talking about? Who wants what? Why? Document goals and next steps. (@djbrooke @TaniaSchlatter @mheppler).

For example, what if we prioritize the position of actions to help establish consistency? Would that feel restrictive to installations? To what degree should or might this be configurable?

  • Create an inventory of current states/use cases. Include objects affected (icons states, drop down items, error/warning messages...)(@djbrooke @TaniaSchlatter @mheppler @scolapasta)
  • Define/confirm scope for launch. What do we need to do to make this feature? Who will do what? Define checklist for detailed design effort.
  • Document, including decisions clearly separated from work process.
  • Use the documented decisions for estimation.

Definition of done for Discovery:

For Design, we need to define logic for what buttons appear when, and have mockups of example display and behavior.

  • Mockups showing Access file drop down: SBGrid and AJPS
  • Mockups showing Preview button (image in this comment and prototype)
  • Mockups showing Ingest warnings
  • Mockups showing Edit (with Kebab)

@mheppler mheppler changed the title Dataset Page Kabobs Dataset Page - File-Level Action Kebob Btn Aug 6, 2020
@mheppler mheppler changed the title Dataset Page - File-Level Action Kebob Btn Dataset Page - File-Level Action Kebob Btn 🍡 Aug 6, 2020
@mheppler mheppler changed the title Dataset Page - File-Level Action Kebob Btn 🍡 Dataset Page - File-Level Action Kebab Btn 🍡 Aug 11, 2020
@mheppler mheppler self-assigned this Aug 18, 2020
@mheppler
Copy link
Contributor

mheppler commented Aug 19, 2020

Changes to file-level action buttons and messages for the file table on the dataset pg and upload/edit files pg have been outlined in the File-Level Actions + Messages doc. They've been reviewed and approved by the design team, and outlined below. See more detail and screenshots of these changes in that doc.

TO-DO LIST

RELATED ISSUES NOT IN SCOPE OF THIS ISSUE

Screen Shot 2020-08-19 at 11 38 11 AM

Screen Shot 2020-08-19 at 11 38 28 AM

Screen Shot 2020-08-19 at 11 38 45 AM

@mheppler mheppler removed their assignment Aug 20, 2020
@mheppler mheppler self-assigned this Aug 24, 2020
@mheppler mheppler changed the title Dataset Page - File-Level Action Kebab Btn 🍡 Dataset Page - File Options Kebab Btn 🍡 Aug 26, 2020
mheppler added a commit that referenced this issue Aug 26, 2020
mheppler added a commit that referenced this issue Sep 2, 2020
@mheppler
Copy link
Contributor

mheppler commented Sep 2, 2020

Dataset pg

  • add new kebab file options icon btn
  • move configure options to new file options dropdown menu
  • add configure options dropdown header
  • add edit options dropdown header
  • add file access icon btn
  • move download, explore, compute options to new file access dropdown menu
  • style ingest in progress file level info msg
  • move, style ingest failed file level warning msg
  • move rsync data access info to new popup linked from Data Access dropdown option under access file icon btn

Upload/Edit Files pg

  • change edit btn to new kebab file options icon btn
  • add edit options dropdown header
  • move, style duplicate file name file level warning msg

File pg

  • move, style ingest failed file level warning msg

Footer

  • add z-index: -1; to CSS to fix layering issue with dropdown menus

Guides

  • removed explore btn reference from Developer Guide > Geospatial Data > Setting Up WorldMap Test Data
  • changed compute btn reference to compute tool options in Installation Guide > Configuration > Setting up Compute with Swift
  • changed download btn reference to access file btn in User Guide > Finding and Using Data > Download Files
  • added reference to new data access option in User Guide > Finding and Using Data > Downloading a Dataverse Package via rsync
  • removed reference to download btn in User Guide > Tabular Data File Ingest > CSV/TSV > Recognized data types and formatting (also fixed cvs-tsv.rst file name with a space in it by renaming it with a hyphen instead)

TO-DO

QUESTIONS

Screen Shot 2020-09-01 at 4 54 03 PM

@mheppler
Copy link
Contributor

mheppler commented Sep 8, 2020

Here are screenshots of the new rsync "Data Access" option under the access file icon btn in the file table on the dataset, plus the new popup displaying the necessary download info.

NOTE my localhost is not properly configured, so the Download Access values are empty and displayed blank in the popup screenshot, also hacked the display logic to show the "Data Access" option for a ZIP file as opposed to a Dataverse Package file.

Screen Shot 2020-09-08 at 12 07 08 PM

Screen Shot 2020-09-08 at 12 31 51 PM

@mheppler mheppler removed their assignment Sep 22, 2020
mheppler added a commit that referenced this issue Oct 7, 2020
mheppler added a commit that referenced this issue Oct 8, 2020
mheppler added a commit that referenced this issue Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants