Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Null banner JSON message fix #10640

Merged
merged 2 commits into from
Jun 20, 2024
Merged

Conversation

jp-tosca
Copy link
Contributor

Which issue(s) this PR closes:

Closes #10638

Suggestions on how to test this:

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:
No, it is an improvement of an error message since the current one display Java/JSON objects as part of the message

@jp-tosca jp-tosca added the Size: 3 A percentage of a sprint. 2.1 hours. label Jun 19, 2024
@coveralls
Copy link

Coverage Status

coverage: 20.657% (-0.004%) from 20.661%
when pulling 1867e30 on banner_null_json_message_fix
into 853965e on develop.

Copy link

📦 Pushed preview images as

ghcr.io/gdcc/dataverse:banner-null-json-message-fix
ghcr.io/gdcc/configbaker:banner-null-json-message-fix

🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name.

@stevenwinship stevenwinship self-assigned this Jun 20, 2024
@jp-tosca jp-tosca marked this pull request as ready for review June 20, 2024 13:48
@stevenwinship stevenwinship merged commit c141941 into develop Jun 20, 2024
18 of 19 checks passed
@stevenwinship stevenwinship deleted the banner_null_json_message_fix branch June 20, 2024 14:33
@stevenwinship stevenwinship removed their assignment Jun 20, 2024
@pdurbin pdurbin added this to the 6.3 milestone Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Size: 3 A percentage of a sprint. 2.1 hours.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Banner error message fails to parse correctly.
5 participants