Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Null banner JSON message fix #10640

Merged
merged 2 commits into from
Jun 20, 2024
Merged

Null banner JSON message fix #10640

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ea0cc4
Null banner JSON message fix
jp-tosca Jun 18, 2024
1867e30
message change
jp-tosca Jun 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/main/java/edu/harvard/iq/dataverse/api/Admin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2337,6 +2337,7 @@ public Response addBannerMessage(JsonObject jsonObject) throws WrappedResponse {

BannerMessage toAdd = new BannerMessage();
try {

String dismissible = jsonObject.getString("dismissibleByUser");

boolean dismissibleByUser = false;
Expand Down Expand Up @@ -2367,7 +2368,7 @@ public Response addBannerMessage(JsonObject jsonObject) throws WrappedResponse {

} catch (Exception e) {
logger.warning("Unexpected Exception: " + e.getMessage());
return error(Status.BAD_REQUEST, "Add Banner Message unexpected exception: " + e.getMessage());
return error(Status.BAD_REQUEST, "Add Banner Message unexpected exception: invalid or missing JSON object.");
}

}
Expand Down
Loading