remove " Dataverse", suggest in watermark on create #3611

[pdurbin]

Places changed:

• header
• breadcrumbs
• search cards
• in-app notifications
• widgets footer
• MyData cards

Note that reindexing is required because the citation is in Solr.

New Contributors

Welcome! New contributors should at least glance at CONTRIBUTING.md, especially the section on pull requests where we encourage you to reach out to other developers before you start coding. Also, please note that we measure code coverage and prefer you write unit tests. Pull requests can still be reviewed without tests or completion of the checklist outlined below. Thanks!

Related Issues

• connects to Customizable dataverse names #3611 Customizable dataverse names

Pull Request Checklist

• Unit tests completed
• Integration tests: None
• Deployment requirements, SQL updates, Solr updates, etc.: Reindex Solr
• Documentation completed
• Merged latest from "develop" branch and resolved conflicts

[coveralls]

Coverage increased (+0.007%) to 10.045% when pulling 6375f9e on 3611-custom-dv-names into 914e4ea on develop.

[coveralls]

Coverage increased (+0.007%) to 10.045% when pulling e855b8a on 3611-custom-dv-names into 914e4ea on develop.

[coveralls]

Coverage increased (+0.007%) to 10.045% when pulling a517e18 on 3611-custom-dv-names into 9ff48e0 on develop.

[coveralls]

Coverage increased (+0.2%) to 10.235% when pulling 77214a5 on 3611-custom-dv-names into 9ff48e0 on develop.

[coveralls]

Coverage increased (+0.02%) to 10.235% when pulling ce77fa2 on 3611-custom-dv-names into dd39e8a on develop.

[coveralls]

Coverage increased (+0.03%) to 10.242% when pulling b8a8c1a on 3611-custom-dv-names into dd39e8a on develop.

[coveralls]

Coverage increased (+0.03%) to 10.242% when pulling 585ec73 on 3611-custom-dv-names into dd39e8a on develop.

[coveralls]

Coverage increased (+0.03%) to 10.243% when pulling 8d4ebdf on 3611-custom-dv-names into dd39e8a on develop.

[coveralls]

Coverage increased (+0.03%) to 10.243% when pulling 52ada78 on 3611-custom-dv-names into dd39e8a on develop.

[coveralls]

Coverage increased (+0.05%) to 10.258% when pulling e8fdd34 on 3611-custom-dv-names into dd39e8a on develop.

[coveralls]

Coverage increased (+0.05%) to 10.26% when pulling 4550e4d on 3611-custom-dv-names into dd39e8a on develop.

[coveralls]

Coverage increased (+0.05%) to 10.261% when pulling c349f1b on 3611-custom-dv-names into 66cb841 on develop.

[coveralls]

Coverage increased (+0.05%) to 10.261% when pulling 2efebf2 on 3611-custom-dv-names into 66cb841 on develop.

[landreev]

Looks good to me.
I obviously didn't go through it line by line; but, even though this PR modifies almost 50 files, it looks pretty straightforward; and the approach makes sense. I like the fact that there are dedicated utilities, like the BrandingUtil, and the tests for them.

[coveralls]

Coverage increased (+0.05%) to 10.261% when pulling eec5a2e on 3611-custom-dv-names into 66cb841 on develop.

[coveralls]

Coverage increased (+0.07%) to 10.286% when pulling 9ffc6b5 on 3611-custom-dv-names into 66cb841 on develop.

[coveralls]

Coverage increased (+0.07%) to 10.286% when pulling 1831c83 on 3611-custom-dv-names into 66cb841 on develop.

[coveralls]

Coverage increased (+0.07%) to 10.285% when pulling 4f131f0 on 3611-custom-dv-names into 66cb841 on develop.