Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API tests failing due to dropping "Dataverse" from dataverse names #3897

Closed
pdurbin opened this issue Jun 13, 2017 · 3 comments
Closed

API tests failing due to dropping "Dataverse" from dataverse names #3897

pdurbin opened this issue Jun 13, 2017 · 3 comments
Assignees
@kcondon
Labels
Component: Code Infrastructure formerly "Feature: Code Infrastructure"
Milestone
4.7 - Customizati...

Comments

@pdurbin
Copy link
Member

pdurbin commented Jun 13, 2017

After merging pull request #3880 having to do with branding, one of the REST Assured tests started failing:

Expected: 403 Not Authorized - Root Dataverse
  Actual: 403 Not Authorized - Root
@pdurbin pdurbin added the Component: Code Infrastructure formerly "Feature: Code Infrastructure" label Jun 13, 2017
pdurbin added a commit that referenced this issue Jun 13, 2017
@pdurbin
don't expect "Dataverse" in name/brand in test #3897
30a7e53 
Also add "dv" to dataverse aliases so they aren't just numbers, which
aren't allowed.
@pdurbin pdurbin changed the title API Tests failing due to dropping "Dataverse" from dataverse names API tests failing due to dropping "Dataverse" from dataverse names Jun 13, 2017
@pdurbin pdurbin mentioned this issue Jun 13, 2017
Merged
5 tasks
@pdurbin
Copy link
Member Author

pdurbin commented Jun 13, 2017

I just created pull request #3898 and moved this to code review at https://waffle.io/IQSS/dataverse

@landreev landreev assigned kcondon and unassigned landreev Jun 20, 2017
kcondon added a commit that referenced this issue Jun 20, 2017
@kcondon
Merge pull request #3898 from IQSS/3897-title-test-brand
76d9fd3 
don't expect "Dataverse" in name/brand in test #3897
@kcondon kcondon closed this as completed Jun 20, 2017
@kcondon
Copy link
Contributor

kcondon commented Jun 20, 2017

Leonid ran tests, confirmed they're working

@pdurbin
Copy link
Member Author

pdurbin commented Jun 20, 2017

Now that the pull request has been merged, all tests on https://build.hmdc.harvard.edu:8443/job/phoenix.dataverse.org-apitest-develop/ are passing again:

screen shot 2017-06-20 at 4 39 01 pm

@djbrooke djbrooke added this to the 4.7 - Dashboard and Customization milestone Jun 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kcondon kcondon

Labels
Component: Code Infrastructure formerly "Feature: Code Infrastructure"
Projects
None yet
Milestone
4.7 - Customization and Community Rel...
Development

No branches or pull requests
4 participants
@pdurbin @landreev @kcondon @djbrooke