Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't expect "Dataverse" in name/brand in test #3897 #3898

Merged
merged 1 commit into from
Jun 20, 2017

Conversation

pdurbin
Copy link
Member

@pdurbin pdurbin commented Jun 13, 2017

Also add "dv" to dataverse aliases so they aren't just numbers, which
aren't allowed.

New Contributors

Welcome! New contributors should at least glance at CONTRIBUTING.md, especially the section on pull requests where we encourage you to reach out to other developers before you start coding. Also, please note that we measure code coverage and prefer you write unit tests. Pull requests can still be reviewed without tests or completion of the checklist outlined below. Thanks!

Related Issues

Pull Request Checklist

Also add "dv" to dataverse aliases so they aren't just numbers, which
aren't allowed.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 10.28% when pulling 30a7e53 on 3897-title-test-brand into e28b927 on develop.

Copy link
Contributor

@landreev landreev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@kcondon kcondon merged commit 76d9fd3 into develop Jun 20, 2017
@kcondon kcondon deleted the 3897-title-test-brand branch June 20, 2017 20:26
pdurbin added a commit that referenced this pull request Oct 20, 2021
(It's only sometimes an integer, of course, randomly.)

This was previously fixed for other tests in pull request #3898.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants