Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change setting of default mode to edit from property to in init method #6828

Merged
merged 1 commit into from
Apr 17, 2020

Conversation

scolapasta
Copy link
Contributor

@scolapasta scolapasta commented Apr 16, 2020

What this PR does / why we need it:
fixes an outstanding viewparam issue for the glassfish to payara upgrade

Which issue(s) this PR closes:

Fix related to #6230

Special notes for your reviewer:
none

Suggestions on how to test this:
from dataset, select one or more files, go to edit, make sure files appear in list

Does this PR introduce a user interface change?:
no

Is there a release notes update needed for this change?:
no

Additional documentation:

@coveralls
Copy link

Coverage Status

Coverage remained the same at 19.629% when pulling c2ea098 on 6230-the-return-of-the-gf-upgrade into 33c6086 on develop.

@pdurbin pdurbin self-assigned this Apr 16, 2020
@pdurbin pdurbin removed their assignment Apr 16, 2020
@kcondon kcondon self-assigned this Apr 17, 2020
@kcondon kcondon merged commit c70faa5 into develop Apr 17, 2020
@kcondon kcondon deleted the 6230-the-return-of-the-gf-upgrade branch April 17, 2020 13:02
@djbrooke djbrooke added this to the Dataverse 5 milestone Apr 17, 2020
pdurbin added a commit to poikilotherm/dataverse that referenced this pull request Apr 22, 2020
We especially want to pick up the bug fix in pull request IQSS#6828.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants