[Feature] Connect to S3 with AWS access key and secret for duckdb #919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wei-Chun, Chang <wcchang@infuseai.io>
Codecov Report
@@ Coverage Diff @@
## main #919 +/- ##
=======================================
Coverage 47.99% 47.99%
=======================================
Files 78 78
Lines 10756 10759 +3
=======================================
+ Hits 5162 5164 +2
- Misses 5594 5595 +1
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
popcornylu
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
What type of PR is this?
feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
sc-32497
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
NONE