Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Connect to S3 with AWS access key and secret for duckdb #919

Merged
merged 1 commit into from
Oct 30, 2023
Merged

[Feature] Connect to S3 with AWS access key and secret for duckdb #919

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions piperider_cli/datasource/duckdb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,15 @@
raise PipeRiderDataBaseConnectionError(self.name, self.type_name, db_path=duckdb_path)
return f"duckdb:///{duckdb_path}"

def engine_args(self):

args = dict(

Check warning on line 109 in piperider_cli/datasource/duckdb.py

View check run for this annotation

Codecov / codecov/patch

piperider_cli/datasource/duckdb.py#L109 

Added line #L109 was not covered by tests
preload_extensions=list(self.credential.get('extensions', [])),
config=dict(self.credential.get('settings', {}))
)

return dict(connect_args=args)

Check warning on line 114 in piperider_cli/datasource/duckdb.py

View check run for this annotation

Codecov / codecov/patch

piperider_cli/datasource/duckdb.py#L114 

Added line #L114 was not covered by tests

def _formalize_table_name(self, name):
if not name:
return f'{self.type_name}_table'
Expand Down
Loading