-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pybind as a dependency in own project; utilities-py; test-split #11147
Conversation
Use PYTHON_EXECUTABLE instead (using PYTHON_PATH). There were also referenced to Python 2.7...
Trying...
|
||
# Now that it's available, we can refer to it with an actual ExternalProject_add (but notice we're not | ||
# downloading anything) | ||
ExternalProject_Add( pybind11 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What will happen here?
I think it will build it again during the build process
Why do we need to build it again?
why not just pybind11_add_module
as before?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as discussed
CMake/unix_config.cmake
Outdated
|
||
# Put all the collaterals together, so we can find when trying to run examples/tests | ||
# Note: this puts the outputs under <binary>/<build-type> | ||
# Note note: this ruins our CI procedures... otherwise it mirrors Windows, simplifies |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a prefix 'We cannot uncomment because this.."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A prefix?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# Note note: this ruins our CI procedures... otherwise it mirrors Windows, simplifies
to
# Note note: We cannot uncomment because it ruins our CI procedures... otherwise it mirrors Windows, simplifies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed
python/cpython#84006 >>> import sysconfig >>> sysconfig.get_config_var('EXT_SUFFIX') '.pyd' >>> from distutils import sysconfig >>> sysconfig.get_config_var('EXT_SUFFIX') '.cp38-win_amd64.pyd' v2.9.2 takes from the previous, v2.9.0 from the latter. So with v2.9.2 we get ABI-less extension which we need. v2.10.1 seems to have fixed this, but we cannot move to it (it deprecates VS2015)...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ran into same issues as before -- updated pybind11 to 2.9.0.