Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pybind as a dependency in own project; utilities-py; test-split #11147

Merged
merged 15 commits into from
Nov 27, 2022
Merged

pybind as a dependency in own project; utilities-py; test-split #11147

merged 15 commits into from
Nov 27, 2022

Commits on Nov 23, 2022

  1. simplify a couple of shared-init.cmake includes

    @maloel
    maloel committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    db14e5b View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2022

  1. remove extra line in source.h

    @maloel
    maloel committed Nov 26, 2022
    Configuration menu
    Copy the full SHA
    849fad7 View commit details
    Browse the repository at this point in the history

  2. add utilities-py w/ common pybind11

    @maloel
    maloel committed Nov 26, 2022
    Configuration menu
    Copy the full SHA
    56c43c0 View commit details
    Browse the repository at this point in the history

  3. replace test-split.cpp with .py

    @maloel
    maloel committed Nov 26, 2022
    Configuration menu
    Copy the full SHA
    9857e22 View commit details
    Browse the repository at this point in the history

  4. update pyrealsense2 and pybackend2

    @maloel
    maloel committed Nov 26, 2022
    Configuration menu
    Copy the full SHA
    3ec18e9 View commit details
    Browse the repository at this point in the history

  5. libci pick up multiple python destination dirs

    @maloel
    maloel committed Nov 26, 2022
    Configuration menu
    Copy the full SHA
    edf2130 View commit details
    Browse the repository at this point in the history

  6. unix output directories now do not get set, still(!)

    @maloel
    maloel committed Nov 26, 2022
    Configuration menu
    Copy the full SHA
    5ea6bbb View commit details
    Browse the repository at this point in the history

  7. fix problem in test-ts-eof

    @maloel
    maloel committed Nov 26, 2022
    Configuration menu
    Copy the full SHA
    809a418 View commit details
    Browse the repository at this point in the history

  8. Remove PYBIND11_PYTHON_VERSION from GHA 

    Use PYTHON_EXECUTABLE instead (using PYTHON_PATH).
There were also referenced to Python 2.7...
    @maloel
    maloel committed Nov 26, 2022
    Configuration menu
    Copy the full SHA
    0321109 View commit details
    Browse the repository at this point in the history

  9. Pybind v2.9.0 -> 2.9.2 

    Trying...
    @maloel
    maloel committed Nov 26, 2022
    Configuration menu
    Copy the full SHA
    0223be8 View commit details
    Browse the repository at this point in the history

  10. PYTHON_PATH no good in unix - use 'which python3'

    @maloel
    maloel committed Nov 26, 2022
    Configuration menu
    Copy the full SHA
    70da794 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2022

  1. remove list(POP_BACK) which requires cmake 3.15

    @maloel
    maloel committed Nov 27, 2022
    Configuration menu
    Copy the full SHA
    92c4b3e View commit details
    Browse the repository at this point in the history

  2. added missing PYTHON_INSTALL_DIR

    @maloel
    maloel committed Nov 27, 2022
    Configuration menu
    Copy the full SHA
    257f974 View commit details
    Browse the repository at this point in the history

  3. Go back to pybind v2.9.0 because of bug 

    python/cpython#84006

>>> import sysconfig
>>> sysconfig.get_config_var('EXT_SUFFIX')
'.pyd'
>>> from distutils import sysconfig
>>> sysconfig.get_config_var('EXT_SUFFIX')
'.cp38-win_amd64.pyd'

v2.9.2 takes from the previous, v2.9.0 from the latter.
So with v2.9.2 we get ABI-less extension which we need.

v2.10.1 seems to have fixed this, but we cannot move to it (it
deprecates VS2015)...
    @maloel
    maloel committed Nov 27, 2022
    Configuration menu
    Copy the full SHA
    e22a46e View commit details
    Browse the repository at this point in the history

  4. revise comment per CR request

    @maloel
    maloel committed Nov 27, 2022
    Configuration menu
    Copy the full SHA
    15db22f View commit details
    Browse the repository at this point in the history