Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EasyLogging - add asynchronous handling (Linux) #8048

Merged
merged 17 commits into from
Jan 26, 2021
Merged

EasyLogging - add asynchronous handling (Linux) #8048

merged 17 commits into from
Jan 26, 2021

Conversation

remibettan
Copy link
Contributor

@remibettan remibettan commented Dec 22, 2020 •
edited by ev-mp
Loading

Tracked on: DSO-16295

@remibettan remibettan force-pushed the el_linux_elpp_messages branch 2 times, most recently from b5835d4 to f24da47 Compare December 24, 2020 15:23
@remibettan remibettan marked this pull request as ready for review December 24, 2020 15:24
ev-mp
ev-mp requested changes Dec 27, 2020
View reviewed changes
Copy link
Collaborator

@ev-mp ev-mp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add unit-tests as discussed

third-party/easyloggingpp/src/easylogging++.cc Outdated Show resolved Hide resolved
third-party/easyloggingpp/src/easylogging++.h Outdated Show resolved Hide resolved
third-party/easyloggingpp/src/easylogging++.h Outdated Show resolved Hide resolved
@remibettan remibettan force-pushed the el_linux_elpp_messages branch 3 times, most recently from 8967923 to 0a83da5 Compare January 5, 2021 09:07
ev-mp
ev-mp requested changes Jan 11, 2021
View reviewed changes
unit-tests/log/test-multi-thread-logs.cpp Outdated Show resolved Hide resolved
third-party/easyloggingpp/src/easylogging++.cc Outdated Show resolved Hide resolved
third-party/easyloggingpp/src/easylogging++.cc Outdated Show resolved Hide resolved
third-party/easyloggingpp/src/easylogging++.h Outdated Show resolved Hide resolved
third-party/easyloggingpp/src/easylogging++.h Outdated Show resolved Hide resolved
third-party/easyloggingpp/src/easylogging++.h Outdated Show resolved Hide resolved
unit-tests/log/test-multi-thread-logs.cpp Show resolved Hide resolved
third-party/easyloggingpp/src/easylogging++.cc Show resolved Hide resolved
unit-tests/log/test-multi-thread-logs.cpp Outdated Show resolved Hide resolved
@remibettan remibettan force-pushed the el_linux_elpp_messages branch 9 times, most recently from b6f07dc to 7f1e16d Compare January 13, 2021 15:37
ev-mp
ev-mp requested changes Jan 13, 2021
View reviewed changes
Copy link
Collaborator

@ev-mp ev-mp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments and fine-tuning

CMake/global_config.cmake Outdated Show resolved Hide resolved
third-party/easyloggingpp/src/easylogging++.cc Outdated Show resolved Hide resolved
third-party/easyloggingpp/src/easylogging++.cc Outdated Show resolved Hide resolved
third-party/easyloggingpp/src/easylogging++.cc Outdated Show resolved Hide resolved
third-party/easyloggingpp/src/easylogging++.cc Outdated Show resolved Hide resolved
unit-tests/log/test-multi-thread-logs.cpp Show resolved Hide resolved
unit-tests/log/test-multi-thread-logs.cpp Outdated Show resolved Hide resolved
unit-tests/log/test-multi-thread-logs.cpp Outdated Show resolved Hide resolved
unit-tests/log/test-multi-thread-logs.cpp Outdated Show resolved Hide resolved
unit-tests/log/test-multi-thread-logs.cpp Outdated Show resolved Hide resolved
maloel
maloel reviewed Jan 14, 2021
View reviewed changes
CMake/global_config.cmake Outdated Show resolved Hide resolved
maloel
maloel reviewed Jan 14, 2021
View reviewed changes
CMake/global_config.cmake Outdated Show resolved Hide resolved
@remibettan remibettan force-pushed the el_linux_elpp_messages branch 2 times, most recently from 2ab8086 to 9d24fd4 Compare January 14, 2021 15:38
remibettan and others added 16 commits January 24, 2021 08:42
@remibettan
enabling async log in linux, , flushAll method adjusted for async log
2119005
@remibettan
easy log methods thread safe fixes
fd5b395
@remibettan
multi-thread logs test added
32d7260
@remibettan
async logger for all os, and with logger internal debug messages
6f57a1a
@remibettan
async log writing to queue not only when logging to file
fb430ff
@remibettan
double queue added
d5d6b6f
@remibettan
moving content from write queue to read queue efficiently
738f3f3
@remibettan
queues changed to deques
90947a6
@remibettan
avoid configuring logger while handling messages
e6a1373
@remibettan
adding pragma ifdef async logger
c5613bc
@remibettan
el async in linux only
c9ab09a
@remibettan
enabling async logger test according to the cmake flag
74ab160
@remibettan
code review corrections - renaming removed and comments added
c19300b
@remibettan
async logger test - target of log action limited to 10 ms instead of …
aef6e13 
…50 ms
@remibettan
async logger test - correctness and performance checkings added
7dd4f90
@remibettan
lock_guard added in test
357d8f8
ev-mp
ev-mp approved these changes Jan 25, 2021
View reviewed changes
Copy link
Collaborator

@ev-mp ev-mp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job

@ev-mp ev-mp merged commit 92c981f into IntelRealSense:development Jan 26, 2021
@ev-mp ev-mp changed the title El linux elpp messages EasyLogging - add asynchronous handling (Linux) Feb 9, 2021
@remibettan remibettan deleted the el_linux_elpp_messages branch March 15, 2021 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maloel maloel maloel left review comments

@ev-mp ev-mp ev-mp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@remibettan @ev-mp @maloel