Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved GenDefn to drasil-theory #1320

Merged
merged 7 commits into from
May 13, 2019
Merged

Moved GenDefn to drasil-theory #1320

merged 7 commits into from
May 13, 2019

Conversation

samm82
Copy link
Collaborator

@samm82 samm82 commented May 13, 2019

As per #918, the drasil-theory package was created, and GenDefn was moved there.

@JacquesCarette - The gd'' constructor (with the following type signature) is never used.

gd'' :: RelationConcept -> [Reference] -> String -> [Sentence] -> GenDefn
  1. Should it be removed?
  2. Should the only other constructor gd' be renamed to gd?

If not, this PR can be merged.

@samm82 samm82 mentioned this pull request May 13, 2019
Closed
5 tasks
@elwazana elwazana mentioned this pull request May 13, 2019
Closed
15 tasks
@JacquesCarette
Copy link
Owner

Yes, please remove gd'' and rename gd' to gd. May as well clean that up before merging.

JacquesCarette
JacquesCarette reviewed May 13, 2019
View reviewed changes
Copy link
Owner

@JacquesCarette JacquesCarette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also it seem that code/drasil-theory/Theory/Drasil/README.md was just copied and doesn't reflect the actual contents?

@samm82
Copy link
Collaborator Author

samm82 commented May 13, 2019

@JacquesCarette I fixed both gd and the README, so this should be good to go.

@JacquesCarette JacquesCarette merged commit 55a5469 into master May 13, 2019
@JacquesCarette
Copy link
Owner

Should I delete the branch, or will you continue to build on it?

@samm82 samm82 deleted the drasilTheory branch May 13, 2019 21:51
@samm82
Copy link
Collaborator Author

samm82 commented May 13, 2019

I'll just make a new one for each move for simplicity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacquesCarette JacquesCarette JacquesCarette approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samm82 @JacquesCarette