Created isLabel and HasLabel classes #643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niazim3
commented
Jun 13, 2018
code/Language/Drasil/LabelHelpers.hs
Outdated
| @@ -0,0 +1,21 @@ | |||
| module Language.Drasil.LabelHelpers (Label) where | |||
There was a problem hiding this comment.
Open to naming suggestions for this file.
|
The convention that I have used is to create i.e. your |
|
This PR is ready for merge. |
samm82
pushed a commit
that referenced
this pull request
Jun 22, 2018
* created isLabel and HasLabel classes * moved newly created classes to Classes file; created new file to avoid cyclic imports * Renamed some files as suggested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for issue #629.
In this PR, the classes
IsLabelandHasLabelare created, addressing theisLabelsection under in #567.@JacquesCarette @szymczdm Is it not desirable to have classes defined anywhere other than the Classes.hs file? I had to move the definitions into the Label.hs file due to cyclic imports (i.e. data type
Labelneeds aUID, which meansLabelis an instance ofHasUID, which needs to be imported from Classes.hs; this meant that defining the new classes in Classes.hs wouldn't work because in order to lens to aLabel, the data typeLabelneeds to be recognized in that file (i.e. Label.hs needs to be imported into Classes.hs)).