Add ShortName to ConceptChunk. #658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first of (probably) a few pull requests to enable/support referencing of
ConceptChunks as per #562 comment 6, third bullet point.In an effort to not break everything, Maybe was added to the ShortName field's type for
ConceptChunk. All existing constructors forConceptChunkhave been updated to "ignore" the short name. Which I believe makes sense as not allConceptChunks will be referenced.@JacquesCarette I misspoke earlier. All the constructors of
ConceptChunktake an existingNP(or type which contains anNP) as input so we don't have theStringmentioned whenShortNamewould be constructed.PS. I will send another PR adding Label related content once #643 has been merged.