Reading from the LCD #58
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is ready for review. Should we support reading back character data from the display? I don't really see a reason for doing so, but it would be trivial to implement |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on the implementations for reading data from the display.
For now, I've only implemented it for blocking I2C.To do this, I splitDataBusinto two traits for reading and writing because depending on the pin configuration, reading may not be possible (and is not required for basic operation).Notable Changes
rwpin was added to 4/8-bit bus pin structs. Instead of a pin,WriteOnlyModecan be specified to opt-out of read features. This requires pulling the RW pin low on the display. This is a breaking change, but easy to adapt.DataBustrait was split into Read* and Write* traits.read_status