Revert "Avoid materializing arrays in bidiag matmul" (#55737)

Reverts #55450. @jishnub suggested reverting this PR to fix #55727.
JuliaLang · Sep 13, 2024 · 2ee6551 · 2ee6551
1 parent 2616634
commit 2ee6551
Show file tree

Hide file tree

Showing 4 changed files with 68 additions and 422 deletions.
diff --git a/stdlib/LinearAlgebra/src/LinearAlgebra.jl b/stdlib/LinearAlgebra/src/LinearAlgebra.jl
@@ -673,9 +673,7 @@ matprod_dest(A::Diagonal, B::Diagonal, TS) = _matprod_dest_diag(B, TS)
 _matprod_dest_diag(A, TS) = similar(A, TS)
 function _matprod_dest_diag(A::SymTridiagonal, TS)
     n = size(A, 1)
-    ev = similar(A, TS, max(0, n-1))
-    dv = similar(A, TS, n)
-    Tridiagonal(ev, dv, similar(ev))
+    Tridiagonal(similar(A, TS, n-1), similar(A, TS, n), similar(A, TS, n-1))
 end
 
 # Special handling for adj/trans vec