Revert "Avoid materializing arrays in bidiag matmul" #55737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7a645dd.
|
I'm not sure if the PR introduces this issue, but that's where I saw this first. Given that this happens unpredictably, I wonder if tests passing here will necessarily suggest that the issue is fixed. After all, tests passed on the PR as well. |
|
For the record, I'm stress-testing this PR by restarting CI several times (not great, but with an intermittent issue and no one finding the underlying culprit I don't see many other options): in 10 rereruns I haven't seen the error reported in #55727 yet |
|
With this PR I couldn't reproduce any error Base.runtests("LinearAlgebra/addmul"; seed=0x8fd036c919ca6b04d09997a08163bff1)
Base.runtests("LinearAlgebra/addmul"; seed=0x86c87ef1d9841135b01925d2cddb12f3)nor getting any failure by launching Base.runtests("LinearAlgebra/addmul")a few hundreds times on a server. I'd say both of these are strong indications that #55450 was indeed the culprit (or exposed an underlying issue?). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #55450. @jishnub suggested reverting this PR to fix #55727.