Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better handling of libgit2 related USE_SYSTEM_* #17884

Closed
yuyichao opened this issue Aug 8, 2016 · 1 comment
Closed

Better handling of libgit2 related USE_SYSTEM_* #17884

yuyichao opened this issue Aug 8, 2016 · 1 comment
Assignees
@tkelman
Labels
domain:building Build system, or building Julia or its dependencies libgit2 The libgit2 library or the LibGit2 stdlib module
Milestone
0.5.0

Comments

@yuyichao
Copy link
Contributor

yuyichao commented Aug 8, 2016

The USE_SYSTEM_* options related to libgit2's ssh/proxy handling roughly works but it seems that they can be handled better/more precisely. A few issues I've noticed,

  1. IIUC mbedtls (and libssh2?) is (are) not used directly but only as dependencies of libgit2. Therefore, when the system version of libgit2 is used, these dependencies shouldn't be built.
  2. USE_SYSTEM_MBEDTLS without USE_SYSTEM_CURL does not work (mbedtls is built).

@tkelman
@tkelman tkelman added the domain:building Build system, or building Julia or its dependencies label Aug 8, 2016
@ViralBShah
Copy link
Member

If libgit2 is SYSTEM, then neither of libcurl, libmbedtls or libssh2 should be built.

@kshyatt kshyatt added the libgit2 The libgit2 library or the LibGit2 stdlib module label Aug 8, 2016
@tkelman tkelman mentioned this issue Aug 10, 2016
Closed
@StefanKarpinski StefanKarpinski added this to the 0.5.0 milestone Aug 10, 2016
@yuyichao yuyichao mentioned this issue Aug 11, 2016
Closed
tkelman added a commit that referenced this issue Aug 20, 2016
@tkelman
Make rpath settings a bit more consistent
e576c87 
probably addresses #18106

(cherry picked from commit fb0e106)
ref #18153

Delete some files from libssh2 and curl that keep changing on travis

causing the cache to get re-uploaded

(cherry picked from commit 71bb974)

Install all 3 mbedtls dlls on windows

and build tests

(cherry picked from commit 6b50d35)

disable libpsl in curl build

should fix clean build of master

indent line continuations

(cherry picked from commit d14f169)

disable using zlib in mbedtls, libssh2, and libcurl

since it requires additional dev headers
fix #18101

(cherry picked from commit f714e83)

Cleanup: replace misleading STAGE#_DEPS variables with DEP_LIBS

(cherry picked from commit 0d634a3)

Improve handling of curl, mbedtls, libssh2 USE_SYSTEM

fix #17884

(cherry picked from commit 4526b65)

Set CMAKE_INSTALL_LIBDIR and CMAKE_INSTALL_BINDIR

in CMAKE_COMMON, so libssh2 installs without an x86_64-linux-gnu
multiarch prefix

(cherry picked from commit bf60b56)

Disable building static mbedtls library

since we don't need it

Go back to just copying the mbedtls dll even in cygwin-cross,
otherwise it puts .dll.a files that we don't need alongside the dlls
(should probably fix this upstream)

(cherry picked from commit 658dc24)

Also just copy libgit2 dll for its install target

since otherwise it puts pkg-config files in LIB_INSTALL_DIR
which we don't need - if mbedtls separates runtime from library
destinations then we could separate BIN_INSTALL_DIR from LIB_INSTALL_DIR
or convince libgit2 to use the standard GNUInstallDirs names

(cherry picked from commit 8e3f1c5)
mfasi pushed a commit to mfasi/julia that referenced this issue Sep 5, 2016
@tkelman @mfasi
Improve handling of curl, mbedtls, libssh2 USE_SYSTEM
57e0afc 
fix JuliaLang#17884
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tkelman tkelman

Labels
domain:building Build system, or building Julia or its dependencies libgit2 The libgit2 library or the LibGit2 stdlib module
Projects
None yet
Milestone
0.5.0
Development

No branches or pull requests
5 participants
@StefanKarpinski @yuyichao @ViralBShah @kshyatt @tkelman