-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zlib is a missing dependency in the README #18101
Comments
We used to build it at one point. |
I was curious why I also had to install development files for OpenSSL. I thought we now use MBedTLS for all SSL/TLS things? |
I believe that is for libgit2. |
OK, thanks for the clarification. Do you think it is feasible to replace OpenSSL entirely with MBedTLS? |
Looks like fixing the openssl dependency is for the 0.6 milestone. |
Where did you get an error for missing zlib-devel headers? We shouldn't absolutely need those. |
I'm not sure if I'm getting the same error that @andyferris was experiencing, but on ubuntu 14.04, without
I was able to build successfully by installing P.S. I also needed to add |
OK I spent the time uninstalling zlib, cloning and making again. This is the end of my compilation (same as @cjprybol):
|
Strange message about perl before the error... not sure what that means? |
That's a bug in mbedtls' cmakelists for out-of-tree builds that I think they've fixed on master, so we'll get it with their next release. Probably harmless since we aren't using their configuration mechanism. We might want to disable mbedtls' usage of zlib then, or if we really need it then build our own from source (and make libgit2 use that one instead of its vendored copy). |
probably addresses #18106 (cherry picked from commit fb0e106) ref #18153 Delete some files from libssh2 and curl that keep changing on travis causing the cache to get re-uploaded (cherry picked from commit 71bb974) Install all 3 mbedtls dlls on windows and build tests (cherry picked from commit 6b50d35) disable libpsl in curl build should fix clean build of master indent line continuations (cherry picked from commit d14f169) disable using zlib in mbedtls, libssh2, and libcurl since it requires additional dev headers fix #18101 (cherry picked from commit f714e83) Cleanup: replace misleading STAGE#_DEPS variables with DEP_LIBS (cherry picked from commit 0d634a3) Improve handling of curl, mbedtls, libssh2 USE_SYSTEM fix #17884 (cherry picked from commit 4526b65) Set CMAKE_INSTALL_LIBDIR and CMAKE_INSTALL_BINDIR in CMAKE_COMMON, so libssh2 installs without an x86_64-linux-gnu multiarch prefix (cherry picked from commit bf60b56) Disable building static mbedtls library since we don't need it Go back to just copying the mbedtls dll even in cygwin-cross, otherwise it puts .dll.a files that we don't need alongside the dlls (should probably fix this upstream) (cherry picked from commit 658dc24) Also just copy libgit2 dll for its install target since otherwise it puts pkg-config files in LIB_INSTALL_DIR which we don't need - if mbedtls separates runtime from library destinations then we could separate BIN_INSTALL_DIR from LIB_INSTALL_DIR or convince libgit2 to use the standard GNUInstallDirs names (cherry picked from commit 8e3f1c5)
Not positive if I caught them all, but that should make manually installing the zlib dev headers unnecessary. If we need it for performance reasons, we could build it separately instead of letting libgit2 use its vendored copy. |
since it requires additional dev headers fix JuliaLang#18101
I got build errors on a brand-new install of Ubuntu 16.04 because it needed to have zlib installed. I resolved the problem by running
sudo apt-get install zlib1g-dev
.The issue is that we should add zlib to the dependencies in the README.md file.
The text was updated successfully, but these errors were encountered: