Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zlib is a missing dependency in the README #18101

Closed
andyferris opened this issue Aug 18, 2016 · 12 comments
Closed

Zlib is a missing dependency in the README #18101

andyferris opened this issue Aug 18, 2016 · 12 comments
Labels
domain:building Build system, or building Julia or its dependencies domain:docs This change adds or pertains to documentation

Comments

@andyferris
Copy link
Member

I got build errors on a brand-new install of Ubuntu 16.04 because it needed to have zlib installed. I resolved the problem by running sudo apt-get install zlib1g-dev.

The issue is that we should add zlib to the dependencies in the README.md file.

@ViralBShah
Copy link
Member

We used to build it at one point.

@andyferris
Copy link
Member Author

I was curious why I also had to install development files for OpenSSL. I thought we now use MBedTLS for all SSL/TLS things?

@ViralBShah
Copy link
Member

I believe that is for libgit2.

@andyferris
Copy link
Member Author

I believe that is for libgit2.

OK, thanks for the clarification. Do you think it is feasible to replace OpenSSL entirely with MBedTLS?

@kshyatt kshyatt added domain:docs This change adds or pertains to documentation domain:building Build system, or building Julia or its dependencies labels Aug 18, 2016
@ViralBShah
Copy link
Member

@wildart or @Keno may be able to explain what's going on here.

@ViralBShah
Copy link
Member

Looks like fixing the openssl dependency is for the 0.6 milestone.

#17471

@tkelman
Copy link
Contributor

tkelman commented Aug 18, 2016

Where did you get an error for missing zlib-devel headers? We shouldn't absolutely need those.

@cjprybol
Copy link
Sponsor Contributor

cjprybol commented Aug 18, 2016

I'm not sure if I'm getting the same error that @andyferris was experiencing, but on ubuntu 14.04, without apt-get install zlib1g-dev, I was experiencing this issue

-- The C compiler identification is GNU 5.3.0
-- Check for working C compiler: /Software/.linuxbrew/bin/gcc
-- Check for working C compiler: /Software/.linuxbrew/bin/gcc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Found Perl: /Software/anaconda3/bin/perl (found version "5.22.0")
Can't open perl script "scripts/config.pl": No such file or directory
-- Could NOT find ZLIB (missing:  ZLIB_LIBRARY ZLIB_INCLUDE_DIR)
CMake Error: The following variables are used in this project, but they are set to NOTFOUND.
Please set them or make sure they are set and tested correctly in the CMake files:
ZLIB_LIBRARY (ADVANCED)
    linked by target "mbedtls_static" in directory /Software/julia/deps/srccache/mbedtls-2.3.0-gpl/library
    linked by target "mbedcrypto" in directory /Software/julia/deps/srccache/mbedtls-2.3.0-gpl/library
    linked by target "mbedx509" in directory /Software/julia/deps/srccache/mbedtls-2.3.0-gpl/library
    linked by target "mbedtls" in directory /Software/julia/deps/srccache/mbedtls-2.3.0-gpl/library
    linked by target "mbedcrypto_static" in directory /Software/julia/deps/srccache/mbedtls-2.3.0-gpl/library
    linked by target "mbedx509_static" in directory /Software/julia/deps/srccache/mbedtls-2.3.0-gpl/library
    linked by target "test_suite_version" in directory /Software/julia/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_ssl" in directory /Software/julia/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_shax" in directory /Software/julia/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_pkwrite" in directory /Software/julia/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_pk" in directory /Software/julia/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_pkcs1_v21" in directory /Software/julia/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_des" in directory /Software/julia/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_debug" in directory /Software/julia/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_blowfish" in directory /Software/julia/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_mpi" in directory /Software/julia/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_ctr_drbg" in directory /Software/julia/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_cipher.padding" in directory /Software/julia/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_gcm.camellia" in directory /Software/julia/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_aes.ecb" in directory /Software/julia/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_x509parse" in directory /Software/julia/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_pkcs5" in directory /Software/julia/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_cipher.ccm" in directory /Software/julia/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_gcm.aes256_en" in directory /Software/julia/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_xtea" in directory /Software/julia/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_hmac_drbg.nopr" in directory /Software/julia/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_cipher.arc4" in directory /Software/julia/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_ecp" in directory /Software/julia/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_gcm.aes128_en" in directory /Software/julia/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_aes.cfb" in directory /Software/julia/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_cipher.null" in directory /Software/julia/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_hmac_drbg.no_reseed" in directory /Software/julia/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_base64" in directory /Software/julia/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_asn1write" in directory /Software/julia/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_pkcs1_v15" in directory /Software/julia/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_cipher.blowfish" in directory /Software/julia/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_memory_buffer_alloc" in directory /Software/julia/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_pkparse" in directory /Software/julia/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_aes.cbc" in directory /Software/julia/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_cipher.gcm" in directory /Software/julia/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_ccm" in directory /Software/julia/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_cipher.camellia" in directory /Software/julia/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_arc4" in directory /Software/julia/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_aes.rest" in directory /Software/julia/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_x509write" in directory /Software/julia/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_camellia" in directory /Software/julia/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_cipher.des" in directory /Software/julia/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_ecdsa" in directory /Software/julia/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_dhm" in directory /Software/julia/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_ecjpake" in directory /Software/julia/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_cipher.aes" in directory /Software/julia/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_error" in directory /Software/julia/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_mdx" in directory /Software/julia/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_rsa" in directory /Software/julia/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_gcm.aes128_de" in directory /Software/julia/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_gcm.aes192_de" in directory /Software/julia/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_gcm.aes192_en" in directory /Software/julia/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_gcm.aes256_de" in directory /Software/julia/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_hmac_drbg.misc" in directory /Software/julia/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_entropy" in directory /Software/julia/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_hmac_drbg.pr" in directory /Software/julia/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_ecdh" in directory /Software/julia/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_md" in directory /Software/julia/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_pem" in directory /Software/julia/deps/srccache/mbedtls-2.3.0-gpl/tests

-- Configuring incomplete, errors occurred!
See also "/Software/julia/deps/build/mbedtls-2.3.0/CMakeFiles/CMakeOutput.log".
make[1]: *** [/Software/julia/deps/mbedtls.mk:40: build/mbedtls-2.3.0/Makefile] Error 1
make: *** [Makefile:81: julia-deps] Error 2

I was able to build successfully by installing zlib1g-dev with apt-get.

P.S. I also needed to add USE_SYSTEM_LIBGIT2:=1 to Make.user because the make process couldn't find the libcurl files in linuxbrew, but I'm just listing that for completeness. Aside from those two additional steps of apt-get install zlib1g-dev and echo "USE_SYSTEM_LIBGIT2:=1" > Make.user, I just ran git checkout release-0.5 and make as per the normal set of instructions

@andyferris
Copy link
Member Author

OK I spent the time uninstalling zlib, cloning and making again. This is the end of my compilation (same as @cjprybol):

libtool: link: (cd ".libs" && rm -f "libgmp.so.10" && ln -s "libgmp.so.10.3.0" "libgmp.so.10")
libtool: link: (cd ".libs" && rm -f "libgmp.so" && ln -s "libgmp.so.10.3.0" "libgmp.so")
libtool: link: ( cd ".libs" && rm -f "libgmp.la" && ln -s "../libgmp.la" "libgmp.la" )
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   321  100   321    0     0    125      0  0:00:02  0:00:02 --:--:--   125
100 1837k  100 1837k    0     0   128k      0  0:00:14  0:00:14 --:--:--  310k
patching file ssl.h
-- The C compiler identification is GNU 5.4.0
-- Check for working C compiler: /usr/bin/gcc
-- Check for working C compiler: /usr/bin/gcc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Found Perl: /usr/bin/perl (found version "5.22.1") 
Can't open perl script "scripts/config.pl": No such file or directory
-- Could NOT find ZLIB (missing:  ZLIB_LIBRARY ZLIB_INCLUDE_DIR) 
CMake Error: The following variables are used in this project, but they are set to NOTFOUND.
Please set them or make sure they are set and tested correctly in the CMake files:
ZLIB_LIBRARY (ADVANCED)
    linked by target "mbedtls_static" in directory /home/ferris/julia-test/deps/srccache/mbedtls-2.3.0-gpl/library
    linked by target "mbedcrypto" in directory /home/ferris/julia-test/deps/srccache/mbedtls-2.3.0-gpl/library
    linked by target "mbedx509" in directory /home/ferris/julia-test/deps/srccache/mbedtls-2.3.0-gpl/library
    linked by target "mbedtls" in directory /home/ferris/julia-test/deps/srccache/mbedtls-2.3.0-gpl/library
    linked by target "mbedcrypto_static" in directory /home/ferris/julia-test/deps/srccache/mbedtls-2.3.0-gpl/library
    linked by target "mbedx509_static" in directory /home/ferris/julia-test/deps/srccache/mbedtls-2.3.0-gpl/library
    linked by target "test_suite_version" in directory /home/ferris/julia-test/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_ssl" in directory /home/ferris/julia-test/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_shax" in directory /home/ferris/julia-test/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_pkwrite" in directory /home/ferris/julia-test/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_pk" in directory /home/ferris/julia-test/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_pkcs1_v21" in directory /home/ferris/julia-test/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_des" in directory /home/ferris/julia-test/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_debug" in directory /home/ferris/julia-test/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_blowfish" in directory /home/ferris/julia-test/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_mpi" in directory /home/ferris/julia-test/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_ctr_drbg" in directory /home/ferris/julia-test/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_cipher.padding" in directory /home/ferris/julia-test/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_gcm.camellia" in directory /home/ferris/julia-test/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_aes.ecb" in directory /home/ferris/julia-test/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_x509parse" in directory /home/ferris/julia-test/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_pkcs5" in directory /home/ferris/julia-test/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_cipher.ccm" in directory /home/ferris/julia-test/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_gcm.aes256_en" in directory /home/ferris/julia-test/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_xtea" in directory /home/ferris/julia-test/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_hmac_drbg.nopr" in directory /home/ferris/julia-test/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_cipher.arc4" in directory /home/ferris/julia-test/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_ecp" in directory /home/ferris/julia-test/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_gcm.aes128_en" in directory /home/ferris/julia-test/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_aes.cfb" in directory /home/ferris/julia-test/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_cipher.null" in directory /home/ferris/julia-test/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_hmac_drbg.no_reseed" in directory /home/ferris/julia-test/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_base64" in directory /home/ferris/julia-test/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_asn1write" in directory /home/ferris/julia-test/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_pkcs1_v15" in directory /home/ferris/julia-test/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_cipher.blowfish" in directory /home/ferris/julia-test/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_memory_buffer_alloc" in directory /home/ferris/julia-test/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_pkparse" in directory /home/ferris/julia-test/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_aes.cbc" in directory /home/ferris/julia-test/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_cipher.gcm" in directory /home/ferris/julia-test/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_ccm" in directory /home/ferris/julia-test/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_cipher.camellia" in directory /home/ferris/julia-test/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_arc4" in directory /home/ferris/julia-test/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_aes.rest" in directory /home/ferris/julia-test/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_x509write" in directory /home/ferris/julia-test/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_camellia" in directory /home/ferris/julia-test/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_cipher.des" in directory /home/ferris/julia-test/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_ecdsa" in directory /home/ferris/julia-test/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_dhm" in directory /home/ferris/julia-test/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_ecjpake" in directory /home/ferris/julia-test/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_cipher.aes" in directory /home/ferris/julia-test/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_error" in directory /home/ferris/julia-test/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_mdx" in directory /home/ferris/julia-test/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_rsa" in directory /home/ferris/julia-test/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_gcm.aes128_de" in directory /home/ferris/julia-test/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_gcm.aes192_de" in directory /home/ferris/julia-test/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_gcm.aes192_en" in directory /home/ferris/julia-test/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_gcm.aes256_de" in directory /home/ferris/julia-test/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_hmac_drbg.misc" in directory /home/ferris/julia-test/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_entropy" in directory /home/ferris/julia-test/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_hmac_drbg.pr" in directory /home/ferris/julia-test/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_ecdh" in directory /home/ferris/julia-test/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_md" in directory /home/ferris/julia-test/deps/srccache/mbedtls-2.3.0-gpl/tests
    linked by target "test_suite_pem" in directory /home/ferris/julia-test/deps/srccache/mbedtls-2.3.0-gpl/tests

-- Configuring incomplete, errors occurred!
See also "/home/ferris/julia-test/deps/build/mbedtls-2.3.0/CMakeFiles/CMakeOutput.log".
/home/ferris/julia-test/deps/mbedtls.mk:43: recipe for target 'build/mbedtls-2.3.0/Makefile' failed
make[1]: *** [build/mbedtls-2.3.0/Makefile] Error 1
Makefile:81: recipe for target 'julia-deps' failed
make: *** [julia-deps] Error 2

@andyferris
Copy link
Member Author

Strange message about perl before the error... not sure what that means?

@tkelman
Copy link
Contributor

tkelman commented Aug 19, 2016

That's a bug in mbedtls' cmakelists for out-of-tree builds that I think they've fixed on master, so we'll get it with their next release. Probably harmless since we aren't using their configuration mechanism. We might want to disable mbedtls' usage of zlib then, or if we really need it then build our own from source (and make libgit2 use that one instead of its vendored copy).

tkelman added a commit that referenced this issue Aug 20, 2016
probably addresses #18106

(cherry picked from commit fb0e106)
ref #18153

Delete some files from libssh2 and curl that keep changing on travis

causing the cache to get re-uploaded

(cherry picked from commit 71bb974)

Install all 3 mbedtls dlls on windows

and build tests

(cherry picked from commit 6b50d35)

disable libpsl in curl build

should fix clean build of master

indent line continuations

(cherry picked from commit d14f169)

disable using zlib in mbedtls, libssh2, and libcurl

since it requires additional dev headers
fix #18101

(cherry picked from commit f714e83)

Cleanup: replace misleading STAGE#_DEPS variables with DEP_LIBS

(cherry picked from commit 0d634a3)

Improve handling of curl, mbedtls, libssh2 USE_SYSTEM

fix #17884

(cherry picked from commit 4526b65)

Set CMAKE_INSTALL_LIBDIR and CMAKE_INSTALL_BINDIR

in CMAKE_COMMON, so libssh2 installs without an x86_64-linux-gnu
multiarch prefix

(cherry picked from commit bf60b56)

Disable building static mbedtls library

since we don't need it

Go back to just copying the mbedtls dll even in cygwin-cross,
otherwise it puts .dll.a files that we don't need alongside the dlls
(should probably fix this upstream)

(cherry picked from commit 658dc24)

Also just copy libgit2 dll for its install target

since otherwise it puts pkg-config files in LIB_INSTALL_DIR
which we don't need - if mbedtls separates runtime from library
destinations then we could separate BIN_INSTALL_DIR from LIB_INSTALL_DIR
or convince libgit2 to use the standard GNUInstallDirs names

(cherry picked from commit 8e3f1c5)
@tkelman
Copy link
Contributor

tkelman commented Aug 21, 2016

Not positive if I caught them all, but that should make manually installing the zlib dev headers unnecessary. If we need it for performance reasons, we could build it separately instead of letting libgit2 use its vendored copy.

mfasi pushed a commit to mfasi/julia that referenced this issue Sep 5, 2016
since it requires additional dev headers
fix JuliaLang#18101
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:building Build system, or building Julia or its dependencies domain:docs This change adds or pertains to documentation
Projects
None yet
Development

No branches or pull requests

5 participants