fix(bootstrap): force lowercase FQDN writing puppet configuration #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Registering production hosts to Katello, I noticed that when an hostname has uppercase characters, then, puppet generates its certificate translating my FQDN to lowercases. While puppet.conf would still mention uppercases. Eventually, puppet agent can't fetch its catalog (403 back from puppetserver). Updating the certname value to match our certificate fixes. One could say that hostnames shouldn't include uppercase characters to begin with. On the other hand, I can't ask my customer to rename production hosts, without being completely certain I'm not disturbing whatever application their servers are running. We could try setting `--fqdn`. Although having a fool-proof puppet configuration might still be relevant (?) Arguably, we could also patch FQDN default value (row 1012) to `socket.getfqdn().lower()`, although I can't guarantee this won't break something else. AFAIU, fixing puppet.conf is just what I need for the bootstrap to execute properly on my customers servers.
|
I agree, fixing the puppet conf only is the cleanest way to do it. I'd ack the change if we can add a comment pointing at Puppet docs (or worst case, source) where they do/expect the A quick glance says https://puppet.com/docs/puppet/5.5/configuration.html#certname is what we want: |
|
LGTM @sideangleside what do you think? |
|
👍 |
evgeni
approved these changes
Aug 10, 2018
evgeni
added a commit
to evgeni/katello-client-bootstrap
that referenced
this pull request
Jan 24, 2019
changelog: * Python 3 support * Capability to preserve proxy settings when reconfiguring/migrating the client (Katello#283) * EL5 subscription manager compatibility fixes (Katello#284) * Only yum clean metadata and dbcache, not RPMs (Katello#280) * Allow defining where to get ssh keys and where to store them (Katello#281) * Make the FIPS check more robust (Katello#279) * Support yum and dnf Python bindings (Katello#271) * Option to ignore registration failures (Katello#261) * Force lowercase FQDN writing puppet configuration (Katello#255) * Improve the error message when a search fails (Katello#257)
Merged
evgeni
added a commit
that referenced
this pull request
Jan 25, 2019
changelog: * Python 3 support * Capability to preserve proxy settings when reconfiguring/migrating the client (#283) * EL5 subscription manager compatibility fixes (#284) * Only yum clean metadata and dbcache, not RPMs (#280) * Allow defining where to get ssh keys and where to store them (#281) * Make the FIPS check more robust (#279) * Support yum and dnf Python bindings (#271) * Option to ignore registration failures (#261) * Force lowercase FQDN writing puppet configuration (#255) * Improve the error message when a search fails (#257)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Registering production hosts to Katello, I noticed that when an
hostname has uppercase characters, then, puppet generates its
certificate translating my FQDN to lowercases. While puppet.conf
would still mention uppercases.
Eventually, puppet agent can't fetch its catalog (403 back from
puppetserver). Updating the certname value to match our certificate
fixes.
One could say that hostnames shouldn't include uppercase characters
to begin with.
On the other hand, I can't ask my customer to rename production hosts,
without being completely certain I'm not disturbing whatever application
their servers are running.
We could try setting
--fqdn. Although having a fool-proof puppetconfiguration might still be relevant (?)
Arguably, we could also patch FQDN default value (row 1012) to
socket.getfqdn().lower(), although I can't guarantee this won'tbreak something else. AFAIU, fixing puppet.conf is just what I need for
the bootstrap to execute properly on my customers servers.