Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFE] add a capability in the bootstrap script to 'preserve proxy' when reconfiguring/migrating the client. #283

Merged
merged 4 commits into from
Jan 7, 2019

Conversation

wbclark
Copy link
Contributor

@wbclark wbclark commented Dec 19, 2018

This PR adds an option --preserve-rhsm-proxy which preserves the proxy settings in /etc/rhsm/rhsm.conf

This was originally requested in https://bugzilla.redhat.com/show_bug.cgi?id=1647631

Copy link
Member

@evgeni evgeni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not a fan of adding another corner-case-fixup to bootstrap, but given it was requested by @sideangleside I'm OK with it :)

Please fix the linting errors. The code looks fine otherwise.

bootstrap.py Outdated Show resolved Hide resolved
bootstrap.py Show resolved Hide resolved
bootstrap.py Outdated Show resolved Hide resolved
bootstrap.py Show resolved Hide resolved
@wbclark
Copy link
Contributor Author

wbclark commented Dec 21, 2018

Hello @evgeni , thank you for your feedback. The requested changes have been made.

Copy link
Member

@evgeni evgeni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inline comment

bootstrap.py Outdated Show resolved Hide resolved
@wbclark
Copy link
Contributor Author

wbclark commented Dec 27, 2018

Hi @evgeni , I have made the change to the variable name within the function. Thanks and happy holidays!

@evgeni evgeni merged commit 02eaac0 into Katello:master Jan 7, 2019
evgeni added a commit to evgeni/katello-client-bootstrap that referenced this pull request Jan 24, 2019
changelog:
* Python 3 support
* Capability to preserve proxy settings when reconfiguring/migrating the client (Katello#283)
* EL5 subscription manager compatibility fixes (Katello#284)
* Only yum clean metadata and dbcache, not RPMs (Katello#280)
* Allow defining where to get ssh keys and where to store them (Katello#281)
* Make the FIPS check more robust (Katello#279)
* Support yum and dnf Python bindings (Katello#271)
* Option to ignore registration failures (Katello#261)
* Force lowercase FQDN writing puppet configuration (Katello#255)
* Improve the error message when a search fails (Katello#257)
@evgeni evgeni mentioned this pull request Jan 24, 2019
evgeni added a commit that referenced this pull request Jan 25, 2019
changelog:
* Python 3 support
* Capability to preserve proxy settings when reconfiguring/migrating the client (#283)
* EL5 subscription manager compatibility fixes (#284)
* Only yum clean metadata and dbcache, not RPMs (#280)
* Allow defining where to get ssh keys and where to store them (#281)
* Make the FIPS check more robust (#279)
* Support yum and dnf Python bindings (#271)
* Option to ignore registration failures (#261)
* Force lowercase FQDN writing puppet configuration (#255)
* Improve the error message when a search fails (#257)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants