-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should image have a name property? #235
Comments
Same question for "shaders": {
"duck0FS": {
"path": "duck0FS.glsl",
"type": 35632
} |
@fabrobinet thoughts? |
I would that allowing our top level entities |
... so it is a yes for |
Agreed. I'll update the schema now. |
My $.02: there is no harm in keeping name fields for these assets... and there might be harm in taking them out. So I say yes. |
Schema is updated. ca69d69 @fabrobinet do we want to keep this open and labled as converter to make any changes to carry through the COLLADA names? |
I'll keep this track that all names are propagated in the converter. (and not only |
Should we be doing this with lights and cameras as well? |
yes - On Thu, Oct 1, 2015 at 4:46 PM, Tom Fili notifications@github.com wrote:
Tony Parisi tparisi@gmail.com Read my books! Programming 3D Applications in HTML5 and |
Added name property to lights, cameras and images in dev-1.0 branch at 1d4370f |
@tfili did you see this:
|
@pjcozzi I'll double check when I get home. |
Great, thanks @tfili! |
thanks @tfili |
Same question as #234 but for an
image
.When I first did the schema I probably carried this over from COLLADA. Do we want to keep a
name
property here?The text was updated successfully, but these errors were encountered: