Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should image have a name property? #235

Closed
pjcozzi opened this issue Feb 20, 2014 · 17 comments
Closed

Should image have a name property? #235

pjcozzi opened this issue Feb 20, 2014 · 17 comments

Comments

@pjcozzi
Copy link
Member

pjcozzi commented Feb 20, 2014

Same question as #234 but for an image.

"images": {
        "image_0": {
            "path": "duckCM.png"
        }
    }

When I first did the schema I probably carried this over from COLLADA. Do we want to keep a name property here?

@pjcozzi
Copy link
Member Author

pjcozzi commented Feb 24, 2014

Same question for shaders:

"shaders": {
        "duck0FS": {
            "path": "duck0FS.glsl",
            "type": 35632
        }

@pjcozzi
Copy link
Member Author

pjcozzi commented Mar 7, 2014

@fabrobinet thoughts?

@fabrobinet
Copy link
Contributor

I would that allowing our top level entities meshes , shaders , programs ... to all have a name that is optional doesn't bring much risk (I mean for legacy) and may be very appreciated when showing informations to users in Viewers UI...

@fabrobinet
Copy link
Contributor

... so it is a yes for image. (but honnestly, I have not a strong opinion on that one).

@pjcozzi
Copy link
Member Author

pjcozzi commented Mar 10, 2014

Agreed. I'll update the schema now.

@tparisi
Copy link
Contributor

tparisi commented Mar 10, 2014

My $.02: there is no harm in keeping name fields for these assets... and there might be harm in taking them out. So I say yes.

@pjcozzi
Copy link
Member Author

pjcozzi commented Mar 10, 2014

Schema is updated. ca69d69

@fabrobinet do we want to keep this open and labled as converter to make any changes to carry through the COLLADA names?

@pjcozzi pjcozzi mentioned this issue Mar 10, 2014
10 tasks
@fabrobinet
Copy link
Contributor

I'll keep this track that all names are propagated in the converter. (and not only image)

@pjcozzi pjcozzi added this to the Converter 1.0 milestone Apr 30, 2014
@pjcozzi pjcozzi removed this from the Converter 1.0 milestone Aug 27, 2015
@tfili
Copy link

tfili commented Oct 1, 2015

Should we be doing this with lights and cameras as well?

@tparisi
Copy link
Contributor

tparisi commented Oct 1, 2015

yes -

On Thu, Oct 1, 2015 at 4:46 PM, Tom Fili notifications@github.com wrote:

Should we be doing this with lights and cameras as well?


Reply to this email directly or view it on GitHub
#235 (comment).

Tony Parisi tparisi@gmail.com
Follow me on Twitter! http://twitter.com/auradeluxe
Read my blog at http://www.tonyparisi.com/
Learn WebGL http://learningwebgl.com/
Mobile 415.902.8002
Skype auradeluxe

Read my books!
Learning Virtual Reality
http://www.amazon.com/Learning-Virtual-Reality-Experiences-Applications/dp/1491922834

Programming 3D Applications in HTML5 and
WebGLhttp://www.amazon.com/Programming-Applications-HTML5-WebGL-Visualization/dp/1449362966
http://www.amazon.com/Programming-Applications-HTML5-WebGL-Visualization/dp/1449362966WebGL,
Up and Running

http://www.amazon.com/dp/144932357X

@tfili
Copy link

tfili commented Oct 2, 2015

Added name property to lights, cameras and images in dev-1.0 branch at 1d4370f

@tfili tfili closed this as completed Oct 2, 2015
@pjcozzi
Copy link
Member Author

pjcozzi commented Oct 2, 2015

@tfili did you also confirm that all names are propagated from COLLADA to glTF?

What about ids (#9)?

@pjcozzi
Copy link
Member Author

pjcozzi commented Oct 5, 2015

@tfili did you see this:

did you also confirm that all names are propagated from COLLADA to glTF?

@tfili
Copy link

tfili commented Oct 5, 2015

@pjcozzi I'll double check when I get home.

@tfili
Copy link

tfili commented Oct 6, 2015

@pjcozzi Looks like skins didn't have it but I added it with 2e9edf0

@pjcozzi
Copy link
Member Author

pjcozzi commented Oct 6, 2015

Great, thanks @tfili!

@tparisi
Copy link
Contributor

tparisi commented Oct 6, 2015

thanks @tfili

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants