Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No error reported to the user when a login attempts fails #2141

Closed
stefankaufmann opened this issue Apr 4, 2024 · 1 comment
Closed

No error reported to the user when a login attempts fails #2141

stefankaufmann opened this issue Apr 4, 2024 · 1 comment
Labels
bug report

Comments

@stefankaufmann
Copy link
Contributor

Bug report

Expected Behavior

If a user tries to login, but the login attempt fails (e.g. because of bad credentials), there should be a feedback provided to the user

Actual Behavior

There is no feedback to the user. The login page is shown again and the login fields are cleared. You can see the 401 in the developer view of the browser, though.

image

CDash Version

v3.3.0

Additional Information

The issue occured with configured LDAP authentication provider. If the credentials are correct, the login works as expected.
stefankaufmann added a commit to stefankaufmann/CDash that referenced this issue Apr 4, 2024
@stefankaufmann
fix Kitware#2141
94cb359
github-merge-queue bot pushed a commit that referenced this issue Apr 4, 2024
@stefankaufmann
Fix #2141 - No error message provided to user for failed login attemp…
5715655 
…ts (#2142)

The issue occurs because the css class `invalid-feedback` contains
`display: none`.
I used this feedback to solve the issue:
https://stackoverflow.com/a/50522718

The screenshot shows an example for a failed LDAP login:

![image](https://github.com/Kitware/CDash/assets/7921443/a9901c7b-447b-438c-99f1-6fb5a2aa1584)
@stefankaufmann
Copy link
Contributor Author

Issue has been fixed in 5715655

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug report
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stefankaufmann