Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2141 - No error message provided to user for failed login attempts #2142

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

stefankaufmann
Copy link
Contributor

The issue occurs because the css class invalid-feedback contains display: none.
I used this feedback to solve the issue: https://stackoverflow.com/a/50522718

The screenshot shows an example for a failed LDAP login:
image

@stefankaufmann stefankaufmann changed the title fix #2141 Fix #2141 - No error message provided to user for failed login attempts Apr 4, 2024
Copy link
Collaborator

@williamjallen williamjallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me. Thanks for this contribution!

@williamjallen williamjallen added this to the v3.4 milestone Apr 4, 2024
@williamjallen williamjallen added this pull request to the merge queue Apr 4, 2024
Merged via the queue into Kitware:master with commit 5715655 Apr 4, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants