Add client-side GraphQL handling #2219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamjallen
force-pushed
the
apollo-client
branch
from
8104ae8
to
fd99623
Compare
sbelsk
reviewed
May 27, 2024
josephsnyder
requested changes
May 28, 2024
There was a problem hiding this comment.
There seems to be some weird interaction with the current time and this update. When between the hour and 10 after, the graphql call reported a 200 response but actually an error had appeared
Once we got to <N>:10, the error disappeared and the GraphQL was able to return data and the page appeared.
|
@josephsnyder Good catch. This issue was the direct result of our nonstandard DateTime format. This PR should wait until #2225 is merged, so we can use ISO 8601 formatted dates for everything instead. |
williamjallen
force-pushed
the
apollo-client
branch
from
9d034f7
to
64cdd14
Compare
Co-authored-by: Shelly Belsky <71195502+sbelsk@users.noreply.github.com>
williamjallen
force-pushed
the
apollo-client
branch
from
64cdd14
to
54290eb
Compare
williamjallen
force-pushed
the
apollo-client
branch
from
54290eb
to
936ed5c
Compare
josephsnyder
approved these changes
Jun 3, 2024
zackgalbreath
requested changes
Jun 3, 2024
zackgalbreath
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apollo is currently the most popular GraphQL client and caching library. This PR eliminates my prior attempt at creating a custom GraphQL client, and sets up Apollo for future use. As a proof-of-concept, I switched
/projectsto a GraphQL backend to demonstrate Apollo's pagination features. While doing so, I added Luxon for easy client-side date handling.Since the API endpoint for
/projectsis no longer used, I have marked it as deprecated, with final removal scheduled for CDash 4.0. Users of this endpoint are advised to use the GraphQL API instead.Reviewers can see the pagination functionality in action by changing the
default_countvalue in/config/lighthouse.phpto a small value.