Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return TZ with DateTime GraphQL results #2225

Merged
merged 1 commit into from
May 31, 2024

Conversation

williamjallen
Copy link
Collaborator

The GraphQL API currently implicitly returns DateTime information in UTC, but this is not necessarily clear to end users, and may not be true in all cases in the future. This PR adds time zone information to each of the DateTime values returned by the API. in accordance with ISO 8601. In the future, we should convert all of our DateTime database columns to DateTimeTz columns.

@williamjallen williamjallen added this to the v3.5 milestone May 29, 2024
Copy link
Member

@josephsnyder josephsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Project pages respect the Nightly Start Time setting and show data in that timezone. viewSubprojects,php has no time zone information, despite it being set for the parent project. Maybe an issue, maybe not!

@zackgalbreath zackgalbreath added this pull request to the merge queue May 30, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 30, 2024
@williamjallen williamjallen added this pull request to the merge queue May 31, 2024
Merged via the queue into Kitware:master with commit 0803420 May 31, 2024
6 checks passed
@williamjallen williamjallen deleted the graphql-datetime-tz branch May 31, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants